pfm migrate validation

middleware/packet-forward-middleware/packetforward/exported/exported.go

@@ -5,6 +5,8 @@ import (
 	paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
 )
 
+// NOTE: this can be removed in SDK v51
+
 type (
 	ParamSet = paramtypes.ParamSet
 

middleware/packet-forward-middleware/packetforward/migrations/v2/migrate.go

@@ -1,6 +1,8 @@
 package v2
 
 import (
+	"fmt"
+
 	"github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v7/packetforward/exported"
 	"github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v7/packetforward/types"
 
@@ -27,5 +29,24 @@ func Migrate(
 
 	bz := cdc.MustMarshal(&currParams)
 	store.Set(types.ParamsKey, bz)
+
+	return validate(store, cdc, currParams)
+}
+
+func validate(store sdk.KVStore, cdc codec.BinaryCodec, currParams types.Params) error {
+	var res types.Params
+	bz := store.Get(types.ParamsKey)
+	if bz == nil {
+		return fmt.Errorf("expected params at key %s but not found", types.ParamsKey)
+	}
+
+	if err := cdc.Unmarshal(bz, &res); err != nil {
+		return err
+	}
+
+	if !currParams.FeePercentage.Equal(res.FeePercentage) {
+		return fmt.Errorf("expected %s but got %s", currParams, res)
+	}
+
 	return nil
 }

middleware/packet-forward-middleware/packetforward/migrations/v2/migrator_test.go

@@ -14,6 +14,9 @@ import (
 	moduletestutil "github.com/cosmos/cosmos-sdk/types/module/testutil"
 )
 
+// 0.02
+var migrateExpected = sdk.NewDecWithPrec(2, 2)
+
 type mockSubspace struct {
 	ps types.Params
 }
@@ -37,7 +40,7 @@ func TestMigrate(t *testing.T) {
 	store := ctx.KVStore(storeKey)
 
 	legacySubspace := newMockSubspace(types.Params{
-		FeePercentage: sdk.NewDec(1),
+		FeePercentage: migrateExpected,
 	})
 	require.NoError(t, v2.Migrate(ctx, store, legacySubspace, cdc))