Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retract v7.1.0s and fix async icq param migration #142

Merged
merged 3 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions middleware/packet-forward-middleware/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,6 @@ replace (
// pin the version of goleveldb to v1.0.1-0.20210819022825-2ae1ddf74ef7 required by SDK v47 upgrade guide.
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7
)

// see https://github.com/cosmos/ibc-apps/pull/141
retract v7.1.0
3 changes: 3 additions & 0 deletions modules/async-icq/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,6 @@ require (
pgregory.net/rapid v0.5.5 // indirect
sigs.k8s.io/yaml v1.3.0 // indirect
)

// see https://github.com/cosmos/ibc-apps/pull/142
retract v7.1.0
2 changes: 1 addition & 1 deletion modules/async-icq/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func (am AppModule) RegisterServices(cfg module.Configurator) {
types.RegisterMsgServer(cfg.MsgServer(), keeper.NewMsgServerImpl(am.keeper))

m := keeper.NewMigrator(&am.keeper, am.legacySubspace)
if err := cfg.RegisterMigration(types.ModuleName, 2, m.Migrate1to2); err != nil {
if err := cfg.RegisterMigration(types.ModuleName, 1, m.Migrate1to2); err != nil {
panic(fmt.Sprintf("failed to migrate x/%s from version 1 to 2: %v", types.ModuleName, err))
}
}
Expand Down
4 changes: 2 additions & 2 deletions modules/async-icq/types/params_legacy.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func ParamKeyTable() paramtypes.KeyTable {
// ParamSetPairs implements params.ParamSet
func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
return paramtypes.ParamSetPairs{
paramtypes.NewParamSetPair(KeyHostEnabled, p.HostEnabled, validateEnabled),
paramtypes.NewParamSetPair(KeyAllowQueries, p.AllowQueries, validateAllowlist),
paramtypes.NewParamSetPair(KeyHostEnabled, &p.HostEnabled, validateEnabled),
paramtypes.NewParamSetPair(KeyAllowQueries, &p.AllowQueries, validateAllowlist),
}
}
Loading