Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ibc-hooks unit tests to work with ibc-go >=7.1.0 #56

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

xlab
Copy link
Contributor

@xlab xlab commented Jul 11, 2023

Resolves issue #57, see for detailed description.

How to test

  1. Checkout the branch: git checkout max/fix-ibc-hooks-escrow
  2. cd modules/ibc-hooks/
  3. Run tests: go test ./...
  4. Try to change go.mod: update ibc-go with github.com/cosmos/ibc-go/v7 v7.2.0
  5. go mod tidy
  6. Run tests again: go test ./...
  7. Profit 🎉

@xlab xlab marked this pull request as ready for review July 11, 2023 20:16
@xlab xlab changed the title fix: ibc-hooks unit tests to work with ibc-go >=0.7.1 fix: ibc-hooks unit tests to work with ibc-go >=7.1.0 Jul 12, 2023
@xlab xlab force-pushed the max/fix-ibc-hooks-escrow branch from 6c81df7 to b963f42 Compare July 12, 2023 08:02
@xlab xlab force-pushed the max/fix-ibc-hooks-escrow branch from b963f42 to 3ea561a Compare July 24, 2023 13:54
Copy link
Contributor

@nicolaslara nicolaslara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@nicolaslara nicolaslara enabled auto-merge (squash) September 14, 2023 07:04
@nicolaslara nicolaslara merged commit b4ca769 into cosmos:main Sep 18, 2023
5 checks passed
@xlab xlab deleted the max/fix-ibc-hooks-escrow branch September 18, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants