test: use non-deprecated gomock package & fix unit tests #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
added
BACKPORT
Reecepbcups
reviewed
Sep 19, 2023
| @@ -147,6 +147,7 @@ mocks: $(MOCKS_DIR) | |||
| mockgen -package=mock -destination=./test/mock/bank_keeper.go $(GOMOD)/router/types BankKeeper | |||
| mockgen -package=mock -destination=./test/mock/ics4_wrapper.go github.com/cosmos/ibc-go/v7/modules/core/05-port/types ICS4Wrapper | |||
| mockgen -package=mock -destination=./test/mock/ibc_module.go github.com/cosmos/ibc-go/v7/modules/core/05-port/types IBCModule | |||
| mockgen -package=mock -destination=./test/mock/channel_keeper.go $(GOMOD)/router/types ChannelKeeper | |||
There was a problem hiding this comment.
Maybe add go install go.uber.org/mock/[email protected] into the mocks target, or a comment to use this for mockgen now.
There was a problem hiding this comment.
good idea, i'll add this now!
Reecepbcups
approved these changes
Sep 19, 2023
|
cc @jtieri this is actually approved now with me being added to the IBCApps team |
thanks! just getting back around to this, i'll add that line to the Makefile target for generating the mocks then get this merged. |
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
* test: use non-deprecated gomock package & fix unit tests * build: add go install cmd to the mocks target * test: fix failing test on empty packet payload (cherry picked from commit b1b6db8) # Conflicts: # middleware/packet-forward-middleware/Makefile # middleware/packet-forward-middleware/go.mod # middleware/packet-forward-middleware/go.sum # middleware/packet-forward-middleware/router/module_test.go # middleware/packet-forward-middleware/test/mock/channel_keeper.go # middleware/packet-forward-middleware/test/mock/ibc_module.go # middleware/packet-forward-middleware/test/mock/ics4_wrapper.go # middleware/packet-forward-middleware/test/mock/transfer_keeper.go # middleware/packet-forward-middleware/test/setup.go
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
* test: use non-deprecated gomock package & fix unit tests * build: add go install cmd to the mocks target * test: fix failing test on empty packet payload (cherry picked from commit b1b6db8) # Conflicts: # middleware/packet-forward-middleware/Makefile # middleware/packet-forward-middleware/go.mod # middleware/packet-forward-middleware/router/module_test.go # middleware/packet-forward-middleware/test/mock/channel_keeper.go # middleware/packet-forward-middleware/test/mock/ibc_module.go # middleware/packet-forward-middleware/test/mock/ics4_wrapper.go # middleware/packet-forward-middleware/test/mock/transfer_keeper.go # middleware/packet-forward-middleware/test/setup.go
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
* test: use non-deprecated gomock package & fix unit tests * build: add go install cmd to the mocks target * test: fix failing test on empty packet payload (cherry picked from commit b1b6db8) # Conflicts: # middleware/packet-forward-middleware/Makefile # middleware/packet-forward-middleware/go.mod # middleware/packet-forward-middleware/router/module_test.go # middleware/packet-forward-middleware/test/mock/channel_keeper.go # middleware/packet-forward-middleware/test/mock/ibc_module.go # middleware/packet-forward-middleware/test/mock/ics4_wrapper.go # middleware/packet-forward-middleware/test/mock/transfer_keeper.go # middleware/packet-forward-middleware/test/setup.go
This was referenced Sep 28, 2023
mergify bot
added a commit
that referenced
this pull request
Oct 2, 2023
…ix unit tests (#115) * test: use non-deprecated gomock package & fix unit tests (#88) * test: use non-deprecated gomock package & fix unit tests * build: add go install cmd to the mocks target * test: fix failing test on empty packet payload (cherry picked from commit b1b6db8) # Conflicts: # middleware/packet-forward-middleware/Makefile # middleware/packet-forward-middleware/go.mod # middleware/packet-forward-middleware/router/module_test.go # middleware/packet-forward-middleware/test/mock/channel_keeper.go # middleware/packet-forward-middleware/test/mock/ibc_module.go # middleware/packet-forward-middleware/test/mock/ics4_wrapper.go # middleware/packet-forward-middleware/test/mock/transfer_keeper.go # middleware/packet-forward-middleware/test/setup.go * fix backport v7 -> v6 * lint --------- Co-authored-by: Justin Tieri <[email protected]> Co-authored-by: Reece Williams <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 2, 2023
…ix unit tests (#114) * test: use non-deprecated gomock package & fix unit tests (#88) * test: use non-deprecated gomock package & fix unit tests * build: add go install cmd to the mocks target * test: fix failing test on empty packet payload (cherry picked from commit b1b6db8) # Conflicts: # middleware/packet-forward-middleware/Makefile # middleware/packet-forward-middleware/go.mod # middleware/packet-forward-middleware/router/module_test.go # middleware/packet-forward-middleware/test/mock/channel_keeper.go # middleware/packet-forward-middleware/test/mock/ibc_module.go # middleware/packet-forward-middleware/test/mock/ics4_wrapper.go # middleware/packet-forward-middleware/test/mock/transfer_keeper.go # middleware/packet-forward-middleware/test/setup.go * fix: backport v7 -> v5 --------- Co-authored-by: Justin Tieri <[email protected]> Co-authored-by: Reece Williams <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 2, 2023
…ix unit tests (#113) * test: use non-deprecated gomock package & fix unit tests (#88) * test: use non-deprecated gomock package & fix unit tests * build: add go install cmd to the mocks target * test: fix failing test on empty packet payload (cherry picked from commit b1b6db8) # Conflicts: # middleware/packet-forward-middleware/Makefile # middleware/packet-forward-middleware/go.mod # middleware/packet-forward-middleware/go.sum # middleware/packet-forward-middleware/router/module_test.go # middleware/packet-forward-middleware/test/mock/channel_keeper.go # middleware/packet-forward-middleware/test/mock/ibc_module.go # middleware/packet-forward-middleware/test/mock/ics4_wrapper.go # middleware/packet-forward-middleware/test/mock/transfer_keeper.go # middleware/packet-forward-middleware/test/setup.go * fix backport v7 -> v4 --------- Co-authored-by: Justin Tieri <[email protected]> Co-authored-by: Reece Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the github.com/golang/mock package has been archived with the suggestion to use the forked version here. this pr replaces the now abandoned repo in favor of the maintained fork and regenerates the mocks.
d72e83c also introduced some breakage in the unit tests which i've fixed.