Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement events for MsgServerV2 #7386

Closed
7 tasks done
Tracked by #7345
chatton opened this issue Oct 2, 2024 · 4 comments · Fixed by #7582
Closed
7 tasks done
Tracked by #7345

Implement events for MsgServerV2 #7386

chatton opened this issue Oct 2, 2024 · 4 comments · Fixed by #7582
Assignees

Comments

@chatton
Copy link
Contributor

chatton commented Oct 2, 2024

Final Packet structure needs to be fully specified before we can do this.

In addition, events for CreateChannel/ProvideCounterparty should also be amended/added:

@chatton chatton moved this to Ready for Development in IBC-GO Eureka Oct 2, 2024
@chatton chatton changed the title Implement events for SendPacket Implement events for MsgServerV2 Oct 7, 2024
@DimitrisJim
Copy link
Contributor

Events also needed for CreateChannel that generated channel identifier (I doubt provide counterparty needs one).

It currently has a bare-bones event emitted since that is needed to run the tests. Can be spec'ed out and changed if needed (currently only emits channelid)

@DimitrisJim
Copy link
Contributor

Spec PR for packet events: cosmos/ibc#1165

@DimitrisJim
Copy link
Contributor

Will wait for packet events until feedback from solidity team is given for them as Aditya requested in call. When spec PR is merged, can pick em up.

@DimitrisJim
Copy link
Contributor

all these should be now done.

@github-project-automation github-project-automation bot moved this from In review to Done in IBC-GO Eureka Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants