Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add events for ack packet. #7584

Closed
wants to merge 3 commits into from
Closed

chore: add events for ack packet. #7584

wants to merge 3 commits into from

Conversation

DimitrisJim
Copy link
Contributor

Description

targets the send packet branch.

part-of: #7386

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Base automatically changed from jim/send-packet-events to feat/ibc-eureka November 21, 2024 14:16
@womensrights womensrights linked an issue Nov 21, 2024 that may be closed by this pull request
Implement events for MsgServerV2 #7386
Closed
7 tasks
@DimitrisJim DimitrisJim mentioned this pull request Nov 21, 2024
Closed
7 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bznein
bznein approved these changes Nov 26, 2024
View reviewed changes
modules/core/04-channel/v2/keeper/packet.go
@@ -230,7 +230,7 @@ func (k *Keeper) acknowledgePacket(ctx context.Context, packet types.Packet, ack
commitment := k.GetPacketCommitment(ctx, packet.SourceChannel, packet.Sequence)
if len(commitment) == 0 {
// TODO: signal noop in events?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] can we remove this comment?

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Dec 2, 2024 •
edited
Loading

Closing, superseded by #7613

@DimitrisJim DimitrisJim closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bznein bznein bznein approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement events for MsgServerV2
3 participants
@DimitrisJim @damiannolan @bznein