feat(depinject): support 08 wasm #6188

DimitrisJim · 2024-04-19T13:03:42Z

Description

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

coderabbitai · 2024-04-19T13:04:23Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

DimitrisJim · 2024-04-19T13:04:46Z

modules/light-clients/08-wasm/testing/simapp/app.go

@@ -662,7 +662,7 @@ func NewSimApp(
 		mockModule,

 		// IBC light clients
-		wasm.NewAppModule(app.WasmClientKeeper), // TODO(damian): see if we want to pass the lightclient module here, keeper is used in AppModule.RegisterServices etc
+		wasm.NewAppModule(wasmLightClientModule), // TODO(damian): see if we want to pass the lightclient module here, keeper is used in AppModule.RegisterServices etc


changed as per todo. unsure if people want to keep keeper for some reason I am not seeing? Will rm the TODO.

DimitrisJim · 2024-04-19T13:05:54Z

modules/light-clients/08-wasm/depinject.go

+		authority = authtypes.NewModuleAddressOrBech32Address(in.Config.Authority)
+	}
+
+	keeper := wasmkeeper.NewKeeperWithVM(


this is kinda troublesome. We could create a struct that encapsulates the config/vm/use mock vm boolean flag? I'd also need to check sdk code to see if there's cases where two different sigs for a keeper exist.

Open to ideas if anyone has em!

Can check some more in depth later today, we can also bring this up tomorrow when syncing with the sdk team.

Not seeing anything equivalent. Best I can see is using optional arguments for vm and vm config and making a decision based on their presence.

DimitrisJim · 2024-04-23T12:01:44Z

modules/light-clients/08-wasm/depinject.go

+			in.Cdc, in.StoreService, in.ClientKeeper, authority.String(), in.VM, in.QueryRouter, in.Opts...,
+		)
+	} else {
+		// TODO(jim): If missing, its default value is used. This could very well be surprising and cause misconfiguration


I guess if default value initialized the config dataDir would be "" which would be non-sensical? Could add validation on config and handle this?

(Note: default value/zero init for interface VM will be nil)

If dataDir is "" maybe an error is already returned in the call to wasmvm.NewVM?

most likely! Would be nice to preempt it and return a better error though.

can leave this TODO here and address it afterwards

sonarcloud · 2024-04-23T12:26:49Z

Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

crodriguezvega

Looks good to me, fine merging this to move forward and come back to it if needed later on.

crodriguezvega · 2024-04-23T13:05:29Z

modules/light-clients/08-wasm/depinject.go

+			in.Cdc, in.StoreService, in.ClientKeeper, authority.String(), in.VM, in.QueryRouter, in.Opts...,
+		)
+	} else {
+		// TODO(jim): If missing, its default value is used. This could very well be surprising and cause misconfiguration


If dataDir is "" maybe an error is already returned in the call to wasmvm.NewVM?

crodriguezvega · 2024-04-29T11:59:49Z

I am going to merge this for now, any improvements can be handled in follow up PRs.

DimitrisJim requested review from colin-axner, AdityaSripal, damiannolan, charleenfei, chatton, srdtrk and crodriguezvega as code owners April 19, 2024 13:03

DimitrisJim commented Apr 19, 2024

View reviewed changes

crodriguezvega added the priority PRs that need prompt reviews label Apr 22, 2024

DimitrisJim added 2 commits April 23, 2024 12:13

feat(depinject): add support for 08-wasm

c4538ea

pass in optional arguments and construct keeper as needed.

50eb53f

DimitrisJim force-pushed the jim/3560-depinject-support-08-wasm branch from 1c13068 to 50eb53f Compare April 23, 2024 11:50

remove pending TODOs

6013514

DimitrisJim commented Apr 23, 2024

View reviewed changes

lint: as always

d82918d

crodriguezvega reviewed Apr 23, 2024

View reviewed changes

crodriguezvega approved these changes Apr 23, 2024

View reviewed changes

crodriguezvega merged commit 29adc7b into feat/depinject Apr 29, 2024
84 checks passed

crodriguezvega deleted the jim/3560-depinject-support-08-wasm branch April 29, 2024 11:59

crodriguezvega mentioned this pull request May 20, 2024

Support SDK dependency injection for v2 apps #3560

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(depinject): support 08 wasm #6188

feat(depinject): support 08 wasm #6188

DimitrisJim commented Apr 19, 2024

coderabbitai bot commented Apr 19, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

DimitrisJim Apr 19, 2024

DimitrisJim Apr 19, 2024

damiannolan Apr 22, 2024

DimitrisJim Apr 23, 2024

DimitrisJim Apr 23, 2024 •

edited

Loading

crodriguezvega Apr 23, 2024

DimitrisJim Apr 23, 2024

DimitrisJim Apr 23, 2024

sonarcloud bot commented Apr 23, 2024

crodriguezvega left a comment

crodriguezvega Apr 23, 2024

crodriguezvega commented Apr 29, 2024

feat(depinject): support 08 wasm #6188

feat(depinject): support 08 wasm #6188

Conversation

DimitrisJim commented Apr 19, 2024

Description

coderabbitai bot commented Apr 19, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DimitrisJim Apr 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Apr 23, 2024

Quality Gate passed for 'ibc-go'

crodriguezvega left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crodriguezvega commented Apr 29, 2024

CodeRabbit Configration File (`.coderabbit.yaml`)

DimitrisJim Apr 23, 2024 •

edited

Loading