refactor(tests): use multidenom by default in relay_test #6767
Conversation
| nil, | ||
| }, | ||
| { | ||
| "successful transfer with non-empty forwarding hops and ics20-2", |
| nil, | ||
| }, | ||
| { | ||
| "successful transfer of IBC token with memo", |
| @@ -162,14 +161,6 @@ func (suite *KeeperTestSuite) TestSendTransfer() { | |||
| }, | |||
| channeltypes.ErrChannelCapabilityNotFound, | |||
| }, | |||
| { | |||
| "failure: timeout height and timeout timestamp are zero", | |||
There was a problem hiding this comment.
was testing packet validation logic, this lead to needing to specify the expected values as 100, 100 even though it failed (because it failed after we had set those amounts and since we just directly send message to function, reverting of state doesnt occur)
| @@ -214,25 +199,28 @@ func (suite *KeeperTestSuite) TestSendTransfer() { | |||
| err = path.RelayPacket(packet) | |||
| suite.Require().NoError(err) | |||
|
|
|||
| // Value that can malleated for Transfer we are testing. | |||
There was a problem hiding this comment.
moved after msg transfer to create ibc denom on a to avoid confusion
DimitrisJim
force-pushed
the
jim/6402-additional-tests-for-multidenom
branch
2 times, most recently
from
3c8fb4b to
9167213
Compare
|
|
||
| // denom trace of tokens received on chain B and the associated expected metadata | ||
| denomOnB := types.NewDenom(sdk.DefaultBondDenom, types.NewHop(path.EndpointB.ChannelConfig.PortID, path.EndpointB.ChannelID)) | ||
| expDenomMetadataOnB := banktypes.Metadata{ |
There was a problem hiding this comment.
this was eye-sore so moved it to separate little func, can add back if people are feeling strongly about this.
DimitrisJim
force-pushed
the
jim/6402-additional-tests-for-multidenom
branch
from
9167213 to
34a6e28
Compare
| suite.Require().NoError(err) // message committed | ||
|
|
||
| packet, err := ibctesting.ParsePacketFromEvents(res.Events) |
There was a problem hiding this comment.
completely refactored this. It was initially sending a packet from B to A, relaying it then doing another transfer from A to B. Simplified to match other receive test, namely, send a packet from A to B and then simulate a packet being received on A that has the right trace to signify A being original source.
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
…on. Add shorthand vars for common sdkmath constants
DimitrisJim
force-pushed
the
jim/6402-additional-tests-for-multidenom
branch
from
6e03d11 to
3a42ac0
Compare
|
Description
first batch for TestSendTransfer and the table OnRecv Is/IsNot Source ones. The ack/timeout ones are main ones left atm.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.