Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mergify for new 08-wasm branches #6771

Merged
merged 1 commit into from
Jul 7, 2024
Merged

chore: mergify for new 08-wasm branches #6771

merged 1 commit into from
Jul 7, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

DimitrisJim
DimitrisJim approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! will we ever backport to previous branches now?

@crodriguezvega
Copy link
Contributor Author

lgtm! will we ever backport to previous branches now?

eh, good question... I don't know. I can delete them in a separate PR and add them if we ever need them again.

@damiannolan
Copy link
Contributor

We might need to for a patch release

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jul 5, 2024 •
edited by crodriguezvega
Loading

wouldn't that incentivize people to potentially use an old incompatible version if they see its getting patch bps?

Let's discuss in the next engineering call (I have added this to the agenda). I will merge this PR for now.

@crodriguezvega crodriguezvega added this pull request to the merge queue Jul 7, 2024
Merged via the queue into main with commit 3005150 Jul 7, 2024
77 checks passed
@crodriguezvega crodriguezvega deleted the carlos/mergify-wasm-branches branch July 7, 2024 20:20
crodriguezvega added a commit that referenced this pull request Jul 8, 2024
@crodriguezvega
mergify for new 08-wasm branches (#6771)
4aab9a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@bznein bznein Awaiting requested review from bznein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crodriguezvega @damiannolan @DimitrisJim