chore(core/02-client): remove legacy proposal types. #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
force-pushed
the
jim/5666-remove-legacy-gov-handlers-types
branch
from
f4fe311 to
5e8e253
Compare
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
DimitrisJim
commented
Jul 9, 2024
Comment on lines
-561
to
-562
| proposal := clienttypes.NewClientUpdateProposal(ibctesting.Title, ibctesting.Description, subjectClientID, substituteClientID) | ||
| s.ExecuteAndPassGovV1Beta1Proposal(ctx, cosmosChain, cosmosWallet, proposal) |
There was a problem hiding this comment.
I believe there's no other sensible thing to do here now, right? (Not that we run these tests atm, but that's besides the point)
There was a problem hiding this comment.
what version did we release wasm in. This should fail compatibility if tested on pre v8
There was a problem hiding this comment.
it would but we don't run compat for 08-wasm. This is typical problem with rm'ing types in newer versions that are used in compat tests. We could get em in e2e if you feel like this is a must. Will slam this in for now.
DimitrisJim
changed the title
colin-axner
approved these changes
Jul 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will add these to changelog/migration docs
#5666 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.