test: e2e upgrade tests for v8 -> v9 #6791
Conversation
gjermundgaraba
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
crodriguezvega,
DimitrisJim and
bznein
as code owners
e2e/testsuite/query/grpc_query.go
Outdated
| } | ||
|
|
||
| // GRPCQueryWithMethod queries the chain with a query request with a specific method (grpc path) and deserializes the response to T | ||
| func GRPCQueryWithMethod[T any](ctx context.Context, chain ibc.Chain, req proto.Message, method string, opts ...grpc.CallOption) (*T, error) { |
There was a problem hiding this comment.
I had to add this, because the v2 query path is not standard and I think it is better to send in the path rather than have a bunch of ifs here.
There was a problem hiding this comment.
upgrade tests are looking great!
We need to make sure we add them to this workflow though.
Currently they are running on this PR because the upgrade test files have changed, but if we want to explicitly trigger upgrade tests, we'll need to add them to that file also!
| @@ -1031,6 +1040,251 @@ func (s *UpgradeTestSuite) TestV8ToV8_1ChainUpgrade_ChannelUpgrades() { | |||
| }) | |||
| } | |||
|
|
|||
| func (s *UpgradeTestSuite) TestV8ToV9ChainUpgrade() { | |||
There was a problem hiding this comment.
not something for today, but it seems like it could be a good idea to parameterize these upgrade tests. It looks like a lot of them are 90% the same.
There was a problem hiding this comment.
I thought about that as well. Another thing I was thinking about was this notion of conformance test that exists in interhcaintest today. If we had a reasonable set of conformance tests we could potentially run them before and after an upgrade and ensure many things at once.
There was a problem hiding this comment.
one of the things I've been thinking about a bit is basically extracting re-usable fns from our existing E2Es and making the actual test cases super short, something like
PerformTransferV1(chainA, chainB)
UpgradeChain(chainA, newVersion)
PerformTransferV2(chainA, chainB)Think it will be possible to reduce a huge amount of duplication in the E2Es.
|
I've added them now, let me know if it looks correct |
Description
Related to #6642
First two tests for v8->v9 upgrade
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.