Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove gov v1beta1 from simapp #6798

Merged
merged 4 commits into from
Jul 10, 2024
Merged

chore: remove gov v1beta1 from simapp #6798

merged 4 commits into from
Jul 10, 2024

Conversation

gjermundgaraba
Copy link
Contributor

Description

closes: #4671

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba gjermundgaraba added the priority PRs that need prompt reviews label Jul 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

damiannolan
damiannolan approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @gjermundgaraba

chatton
chatton approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🥇

DimitrisJim
DimitrisJim approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 07316fa Jul 10, 2024
70 of 71 checks passed
@DimitrisJim DimitrisJim deleted the gjermund/4671-remove-gov-v1beta1-router-from-simapp branch July 10, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@chatton chatton chatton approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@bznein bznein Awaiting requested review from bznein

Assignees
No one assigned
Labels
priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove gov v1beta1 router from simapp
4 participants
@gjermundgaraba @damiannolan @chatton @DimitrisJim