docs: migration doc updates for 08-wasm v8 to v9 #6845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjermundgaraba
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
There was a problem hiding this comment.
This looks good; thank you, @gjermundgaraba! We should move the whole 08-wasm section to the specific migration docs file for 08-wasm. We can have a heading like From ibc-go v8.3.x to ibc-go v9.0.x
| @@ -210,9 +210,20 @@ The `IterateConsensusMetadata` function has been removed. | |||
|
|
|||
| ### 08-wasm | |||
|
|
|||
| - The `Initialize`, `Status`, `GetTimestampAtHeight`, `GetLatestHeight`, `VerifyMembership`, `VerifyNonMembership`, `VerifyClientMessage`, `UpdateState` and `UpdateStateOnMisbehaviour` functions in `ClientState` have been removed and all their logic has been moved to functions of the `LightClientModule`. | |||
| - The `MigrateContract()` function has been removed from `ClientState`. | |||
There was a problem hiding this comment.
nit: I don't feel strongly about using () when we refer to functions, but for consistency with the rest of the document we should either remove them or add them to all. If you want, I can take care of this.
There was a problem hiding this comment.
Fine with removing the parentheses 👍🏻
damiannolan
approved these changes
Jul 17, 2024
| @@ -210,9 +210,20 @@ The `IterateConsensusMetadata` function has been removed. | |||
|
|
|||
| ### 08-wasm | |||
|
|
|||
| - The `Initialize`, `Status`, `GetTimestampAtHeight`, `GetLatestHeight`, `VerifyMembership`, `VerifyNonMembership`, `VerifyClientMessage`, `UpdateState` and `UpdateStateOnMisbehaviour` functions in `ClientState` have been removed and all their logic has been moved to functions of the `LightClientModule`. | |||
| - The `MigrateContract()` function has been removed from `ClientState`. | |||
There was a problem hiding this comment.
Fine with removing the parentheses 👍🏻
DimitrisJim
approved these changes
Jul 17, 2024
crodriguezvega
approved these changes
Jul 19, 2024
gjermundgaraba
deleted the
gjermund/6139-update-08-wasm-documentation-and-migration-docs-for-v04x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6139
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.