chore: update to 0.52 #7261
Draft
chore: update to 0.52 #7261
+5,817
−6,488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
force-pushed
the
marko/gomod_change
branch
from
2bb67b5
to
0832575
Compare
* Remove module.HasProposalMsgs * Update ante handler * Bump versions * x * Cleanup
damiannolan
reviewed
Nov 20, 2024
| } | ||
|
|
||
| // allow the following addresses to receive funds | ||
| delete(modAccAddrs, authtypes.NewModuleAddress(govtypes.ModuleName).String()) | ||
| delete(modAccAddrs, authtypes.NewModuleAddress(ibcmock.ModuleName).String()) |
There was a problem hiding this comment.
Just dropping a note here. We also need to delete ibc mock module address from blocked addresses (for usage in tests, was causing some failures)
Will change on other branch
chore: test fixes and updates for olympus upgrade
damiannolan
reviewed
Nov 21, 2024
testing/chain.go
Outdated
| @@ -388,7 +396,7 @@ func (chain *TestChain) SendMsgs(msgs ...sdk.Msg) (*abci.ExecTxResult, error) { | |||
| txResult := resp.TxResults[0] | |||
|
|
|||
| if txResult.Code != 0 { | |||
| return txResult, fmt.Errorf("%s/%d: %q", txResult.Codespace, txResult.Code, txResult.Log) | |||
There was a problem hiding this comment.
We'll have to revert this. It rugs some tests.
Any reason to remove log here?
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.