use procs over methods for callbacks

better performance

lib/libuv/file.rb

@@ -148,10 +148,12 @@ def chown(uid:, gid:, wait: true)
         end
 
         def send_file(stream, using: :raw, chunk_size: 4096, wait: true)
-            @transmit_failure ||= method(:transmit_failure)
-            @transmit_data ||= method(:transmit_data)
-            @start_transmit ||= method(:start_transmit)
-            @next_chunk ||= method(:next_chunk)
+            @transmit_failure ||= proc { |reason| @sending_file.reject(reason) }
+            @start_transmit ||= proc { |stats|
+                @file_stream_total = stats[:st_size]
+                next_chunk
+            }
+            @transmit_data ||= proc { |data| transmit_data(data) }
 
             @sending_file = @reactor.defer
             @file_stream = stream
@@ -162,7 +164,7 @@ def send_file(stream, using: :raw, chunk_size: 4096, wait: true)
             stat(wait: false).then @start_transmit, @transmit_failure
 
             promise = @sending_file.promise
-            promise.finally &method(:clean_up_send)
+            promise.finally { clean_up_send }
             respond wait, promise
         end
 
@@ -172,11 +174,6 @@ def send_file(stream, using: :raw, chunk_size: 4096, wait: true)
 
         ##
         # File transmit functions -------------
-        def start_transmit(stats)
-            @file_stream_total = stats[:st_size]
-            next_chunk
-        end
-
         def transmit_data(data)
             @file_chunk_count += 1
             if @file_stream_type == :http
@@ -186,11 +183,11 @@ def transmit_data(data)
                 resp << CRLF
                 data = resp
             end
-            @file_stream.write(data, wait: :promise).then @next_chunk, @transmit_failure
+            @file_stream.write(data, wait: :promise).then(proc { next_chunk }, @transmit_failure)
             nil
         end
 
-        def next_chunk(*args)
+        def next_chunk
             next_size = @file_chunk_size
             next_offset = @file_chunk_size * @file_chunk_count
 
@@ -211,10 +208,6 @@ def next_chunk(*args)
             nil
         end
 
-        def transmit_failure(reason)
-            @sending_file.reject(reason)
-        end
-
         def clean_up_send
             @sending_file = nil
             @file_stream = nil

lib/libuv/pipe.rb

@@ -25,7 +25,7 @@ def initialize(reactor, ipc, acceptor = nil)
         def bind(name, &callback)
             return if @closed
             @on_accept = callback
-            @on_listen = method(:accept)
+            @on_listen = proc { accept }
 
             assert_type(String, name, "name must be a String")
             name = windows_path name if FFI::Platform.windows?
@@ -158,7 +158,7 @@ def getsockname
         private
 
 
-        def accept(_)
+        def accept
             pipe = nil
             begin
                 raise RuntimeError, CLOSED_HANDLE_ERROR if @closed

lib/libuv/reactor.rb

@@ -62,15 +62,15 @@ def initialize(pointer) # :notnew:
 
             # Create an async call for scheduling work from other threads
             @run_queue = Queue.new
-            @process_queue = @reactor.async &method(:process_queue_cb)
+            @process_queue = @reactor.async { process_queue_cb }
             @process_queue.unref
 
             # Create a next tick timer
-            @next_tick = @reactor.timer &method(:next_tick_cb)
+            @next_tick = @reactor.timer { next_tick_cb }
             @next_tick.unref
 
             # Create an async call for ending the reactor
-            @stop_reactor = @reactor.async &method(:stop_cb)
+            @stop_reactor = @reactor.async { stop_cb }
             @stop_reactor.unref
 
             # Libuv can prevent the application shutting down once the main thread has ended
@@ -82,7 +82,7 @@ def initialize(pointer) # :notnew:
             # LibUV ingnores program interrupt by default.
             # We provide normal behaviour and allow this to be overriden
             @on_signal = []
-            sig_callback = method(:signal_cb)
+            sig_callback = proc { signal_cb }
             self.signal(:INT, &sig_callback).unref
             self.signal(:HUP, &sig_callback).unref
             self.signal(:TERM, &sig_callback).unref
@@ -108,7 +108,7 @@ def stop_cb
             ::Libuv::Ext.stop(@pointer)
         end
 
-        def signal_cb(_)
+        def signal_cb
             if @on_signal.empty?
                 stop_cb
             else

lib/libuv/tcp.rb

@@ -199,7 +199,7 @@ def write(data, wait: false)
         alias_method :do_shutdown, :shutdown
         def shutdown
             if @pending_writes && @pending_writes.length > 0
-                @pending_writes[-1][0].finally method(:do_shutdown)
+                @pending_writes[-1][0].finally { do_shutdown }
             else
                 do_shutdown
             end
@@ -232,7 +232,7 @@ def bind(ip, port, **tls_options, &blk)
             return self if @closed
 
             @on_accept = blk
-            @on_listen = method(:accept)
+            @on_listen = proc { accept }
 
             assert_type(String, ip, IP_ARGUMENT_ERROR)
             assert_type(Integer, port, PORT_ARGUMENT_ERROR)
@@ -253,7 +253,7 @@ def open(fd, binding = true)
             return self if @closed
 
             if binding
-                @on_listen = method(:accept)
+                @on_listen = proc { accept }
                 @on_accept = Proc.new
             elsif block_given?
                 @callback = Proc.new
@@ -382,7 +382,7 @@ def on_connect(req, status)
             end
         end
 
-        def accept(_)
+        def accept
             begin
                 raise RuntimeError, CLOSED_HANDLE_ERROR if @closed
                 tcp = TCP.new(reactor, handle, **@tls_options)