Changes to support 'liteserv' #2117
Draft
+3,191
−4,338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snej
force-pushed
the
feature/changes-feed
branch
from
301b4af to
ea4b302
Compare
|
Code Coverage Results:
|
snej
force-pushed
the
feature/changes-feed
branch
5 times, most recently
from
a93a5cd to
fce880d
Compare
snej
force-pushed
the
feature/changes-feed
branch
2 times, most recently
from
9f1c40f to
3e0870a
Compare
snej
changed the title
snej
force-pushed
the
feature/changes-feed
branch
from
9b374ba to
d768e61
Compare
snej
force-pushed
the
feature/changes-feed
branch
2 times, most recently
from
c18b18a to
e24e1a6
Compare
snej
force-pushed
the
feature/changes-feed
branch
2 times, most recently
from
5343df2 to
69007df
Compare
- Removed RESTListener - Misc. internal API additions / changes / fixes
WITH_ERROR can't use Catch's UNSCOPED_INFO(), but I've amended it to use WARN(), which will also show up in the test results.
If the pool is opened with a read-only db, then borrowWriteable() should immediately throw NotWriteable, not wait for a db to be returned and then throw Busy.
c4Replicator+Pool.hh defines factory functions to start a replicator given a DatabasePool* not a C4Database*. This shields callers from having to include c4DatabaseImpl.hh etc., which drag in a buttload of internal replicator headers.
Gives Task subclasses more control over when a finished task should be removed from the listing. Needed for ChangesTask.
Return value is true if index was created or replaced, false if nothing changed.
Requires updating EE repo
- clang-format - BorrowedCollection retains its C4Collection - Fixed warnings about out-of-order initializers - Fixed some params that needed C4NULLABLE - Removed unused SyncListener member variables
snej
force-pushed
the
feature/changes-feed
branch
from
a2a887c to
b12952a
Compare
CBL_CORE_API shouldn't be used on the _definitions_ of data values, only their _declarations_.
This occurs when EdgeServer sends an HTTP response but the client has closed the socket.
clang-format reformats the declaration of "challengeAuth" weirdly, with a two-line comment that has a '\' at the end of the first line. GCC warns about this with -Wall. Moved the doc-comment above the declaration to prevent this.
Internally, I streamlined the RecordEnumerator API by folding the other initialization parameters into the Options struct.
snej
force-pushed
the
feature/changes-feed
branch
from
edcb1c0 to
49ca97c
Compare
snej
changed the title
snej
force-pushed
the
feature/changes-feed
branch
from
452fd24 to
555bd56
Compare
- ICU is now downloaded as part of the build - No more top level build server CMake wrapper is needed - LiteCore and LiteCoreStatic targets can be disabled to avoid having needless install output - Move sTempDir into LogEncoderTest.cc so it can be shared between CppTests and cbl-logtest
for EdgeServer, as part of creating Etags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains all the LiteCore enhancements & fixes needed to implement the
liteservserver._changesendpoint of the REST API, all 3 modes (normal, longpoll, continuous.) The latter two modes often have to block waiting for new changes; the implementation using Listener::Task ensures these idle connections aren't blocking a thread or locking a database, so it should be very scalable._queryendpoint for running queries._replicateendpoint:cancelAPI to take the session_id