feat: make the conditional order factory case insensitive #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are observing some issues handling some TWAP orders in the logs.
According to the log, this message should only be shown for legacy polling, meaning that the order was not recognised as a known one, and instead of using the SDK polling for Conditional Orders, its using the generic polling of the Watch Tower.
The check if the order is a known one is based on the
ConditionalOrderFactory
who instanciates conditional orders based on their handler.I can see in the error the handler is TWAP, but it was not instantiated using the SDK which I believe it means the handler was not recognised.
This PR makes the
ConditionalOrderFactory
to not be case sensitive, because otherwise it depends on the casing of the handler if its recognised or not. With this, the legacy polling should not be used for TWAP.After this PR
After this PR we need to generate a new SDK version and make use of it in Watch Tower