chore: follow up on #3301 (#3309)

* chore: bring back some disabled tests * chore: simplify scripts * fix: remove legacy regex from gnosis * chore: simplify scripts
cowprotocol · Nov 1, 2023 · 21b59b6 · 21b59b6
1 parent 866004c
commit 21b59b6
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 10 deletions.
diff --git a/apps/cowswap-frontend-e2e/src/e2e/swapMod.test.ts b/apps/cowswap-frontend-e2e/src/e2e/swapMod.test.ts
@@ -93,7 +93,7 @@ describe('Swap (mod)', () => {
       cy.get('#toggle-recipient-mode-button').click()
     })
 
-    it.only('Recipient is visible', () => {
+    it('Recipient is visible', () => {
       cy.get('#recipient').should('exist')
     })
   })

diff --git a/apps/cowswap-frontend/project.json b/apps/cowswap-frontend/project.json
@@ -8,7 +8,7 @@
       "executor": "@nx/vite:build",
       "outputs": ["{options.outputPath}"],
       "defaultConfiguration": "production",
-      "dependsOn": ["i18n:compile"],
+      "dependsOn": ["i18n"],
       "options": {
         "outputPath": "build/cowswap"
       },
@@ -75,10 +75,6 @@
     },
 
     "i18n": {
-      "executor": "nx:noop",
-      "dependsOn": ["i18n:compile"]
-    },
-    "i18n:compile": {
       "executor": "nx:run-commands",
       "dependsOn": ["i18n:extract"],
       "options": {

diff --git a/libs/common-utils/src/environments.test.ts b/libs/common-utils/src/environments.test.ts
@@ -20,7 +20,7 @@ describe('Detect environments using host and path', () => {
     })
   })
 
-  describe.only('Is production', () => {
+  describe('Is production', () => {
     const isProduction = { ...DEFAULT_ENVIRONMENTS_CHECKS, isProd: true }
 
     it('swap.cow.fi', () => {

diff --git a/libs/common-utils/src/environments.ts b/libs/common-utils/src/environments.ts
@@ -2,7 +2,7 @@ import { registerOnWindow } from './misc'
 
 const DEFAULT_ENVIRONMENTS_REGEX: Record<Envs, string> = {
   LOCAL: '^(:?localhost:\\d{2,5}|(?:127|192)(?:\\.[0-9]{1,3}){3})',
-  PR: '^pr\\d+--cowswap\\.review|^(swap-dev-git-[\\w\\d-]+|swap-\\w{9}-)cowswap\\.vercel\\.app',
+  PR: '^(swap-dev-git-[\\w\\d-]+|swap-\\w{9}-)cowswap\\.vercel\\.app',
   DEV: '^(dev.swap.cow.fi|swap-develop.vercel.app)',
   STAGING: '^(staging.swap.cow.fi|swap-staging.vercel.app)',
   PROD: '^(swap.cow.fi|swap-prod.vercel.app)$',

diff --git a/package.json b/package.json
@@ -23,8 +23,7 @@
     "ipfs:publish": "npx ipfs-deploy build -p pinata -O",
     "i18n": "nx run-many -t i18n",
     "preview": "cross-env NODE_OPTIONS=--max-old-space-size=32768 nx run cowswap-frontend:preview",
-    "test": "yarn test:all",
-    "test:all": "nx run-many -t test",
+    "test": "nx run-many -t test",
     "e2e": "nx run-many -t e2e",
     "lint": "nx run-many -t lint",
     "prebuild-app": "yarn i18n",