Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: UI Adjustment #5268

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

p-andhika
Copy link

Summary

Fixes #5218

Adjust filter button style and align icon.

1 2 3

To Test

Test with:

  • /address/0x79063d9173C09887d536924E2F6eADbaBAc099f5
  • /address/0x5be9a4959308A0D0c7bC0870E319314d8D957dBB
  • /orders/0x193373799f499aacd7b1aba2e7aec366079f5b303d8f97e3ca8ab2a46998d1c45be9a4959308a0d0c7bc0870e319314d8d957dbb678d03ce?tab=overview

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview Jan 6, 2025 2:42pm
sdk-tools ✅ Ready (Inspect) Visit Preview Jan 6, 2025 2:42pm

Copy link

vercel bot commented Jan 3, 2025

@andhika-agriaku is attempting to deploy a commit to the cow Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@p-andhika
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@p-andhika
Copy link
Author

recheck

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks a lot for your contribution! Really appreciate it.

Second, it works great!

But I have a concern regarding the component being used. Please see the comment in the code.

@@ -1,5 +1,6 @@
import React from 'react'

import { FloatingButton } from 'explorer/components/TransanctionBatchGraph/styled'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That component really shouldn't be used here, as it belong to a completely different component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer: UI issues related to orders filtering
2 participants