Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: UI Adjustment #5268

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Conversation

p-andhika
Copy link
Contributor

Summary

Fixes #5218

Adjust filter button style and align icon.

1 2 3

To Test

Test with:

  • /address/0x79063d9173C09887d536924E2F6eADbaBAc099f5
  • /address/0x5be9a4959308A0D0c7bC0870E319314d8D957dBB
  • /orders/0x193373799f499aacd7b1aba2e7aec366079f5b303d8f97e3ca8ab2a46998d1c45be9a4959308a0d0c7bc0870e319314d8d957dbb678d03ce?tab=overview

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview Jan 13, 2025 9:57am
1 Skipped Deployment
Name Status Preview Updated (UTC)
sdk-tools ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:57am

Copy link

vercel bot commented Jan 3, 2025

@andhika-agriaku is attempting to deploy a commit to the cow Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@p-andhika
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@p-andhika
Copy link
Contributor Author

recheck

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks a lot for your contribution! Really appreciate it.

Second, it works great!

But I have a concern regarding the component being used. Please see the comment in the code.

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @p-andhika , thank you so much for your contribution!

Could you please improve the buttons' view on a reduced (and mobile) screens?
image

Also, there are some new issues appeared on an order details page: buttons' layout has been changed, the icon has become center-aligned. Could you please fix this?
image

And there is one nitpick from my side (sorry, I did not mention about it in the original task): might it be possible to highlight the selected filtering option? See the comparison with the Prod version where the option is highlighted with a color:
image
The easiest option is to leave the orange color we have on 'hover' action
image

Thank you!

@p-andhika
Copy link
Contributor Author

@elena-zh I've adjusted it, thanks!

@elena-zh
Copy link
Contributor

elena-zh commented Jan 8, 2025

Hey @p-andhika , great, thank you!
The last uber-nitpick: the button's color change (active/not active) is not properly working in a real mobile device (iOS 17.6.1 +Chrome). See the video:

video_2025-01-08_19-28-54.mp4

Might it be possible to fix it?

@p-andhika
Copy link
Contributor Author

@elena-zh , this is what we can do:

ScreenRecording_01-09-2025.20-18-20_1.MP4

Please check again, thanks!

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Approved

@alfetopito alfetopito merged commit 7d3242c into cowprotocol:develop Jan 13, 2025
4 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer: UI issues related to orders filtering
3 participants