-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explorer: UI Adjustment #5268
Explorer: UI Adjustment #5268
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@andhika-agriaku is attempting to deploy a commit to the cow Team on Vercel. A member of the Team first needs to authorize it. |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks a lot for your contribution! Really appreciate it.
Second, it works great!
But I have a concern regarding the component being used. Please see the comment in the code.
apps/explorer/src/components/orders/OrdersUserDetailsTable/ToggleFilter.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @p-andhika , thank you so much for your contribution!
Could you please improve the buttons' view on a reduced (and mobile) screens?
Also, there are some new issues appeared on an order details page: buttons' layout has been changed, the icon has become center-aligned. Could you please fix this?
And there is one nitpick from my side (sorry, I did not mention about it in the original task): might it be possible to highlight the selected filtering option? See the comparison with the Prod version where the option is highlighted with a color:
The easiest option is to leave the orange color we have on 'hover' action
Thank you!
@elena-zh I've adjusted it, thanks! |
Hey @p-andhika , great, thank you! video_2025-01-08_19-28-54.mp4Might it be possible to fix it? |
@elena-zh , this is what we can do: ScreenRecording_01-09-2025.20-18-20_1.MP4Please check again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Approved
Summary
Fixes #5218
Adjust filter button style and align icon.
To Test
Test with:
/address/0x79063d9173C09887d536924E2F6eADbaBAc099f5
/address/0x5be9a4959308A0D0c7bC0870E319314d8D957dBB
/orders/0x193373799f499aacd7b1aba2e7aec366079f5b303d8f97e3ca8ab2a46998d1c45be9a4959308a0d0c7bc0870e319314d8d957dbb678d03ce?tab=overview