Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(twap): display order group in history tab #2948

Merged
merged 1 commit into from
Jul 31, 2023
Merged

feat(twap): display order group in history tab #2948

merged 1 commit into from
Jul 31, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Jul 27, 2023 •
edited
Loading

Summary

Fixes #2941

Now twap order always displays as a group with all parts inside.
Only when all parts are completed (canceled/expired/filled) then the whole twap order moves to the history.

image

@shoom3301 shoom3301 added the TWAP label Jul 27, 2023
@shoom3301 shoom3301 requested review from a team July 27, 2023 11:06
@shoom3301 shoom3301 self-assigned this Jul 27, 2023
@vercel
Copy link

vercel bot commented Jul 27, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 11:13am

alfetopito
alfetopito approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very nice!

Nitpick, not necessarily for this PR:
Should we auto-navigate to the page were the active order is?

This extreme case for example. 100 parts, 30 something already past.
The next active order is on page 4
image

elena-zh
elena-zh reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shoom3301 , awesome!
Just some questions/nitpicks:

  1. Maybe we should not show 'Expires' time to a Filled/Cancelled orders?
    image
  2. I tested the case when a part expired due to no balance, then returned the balance back. The next part was successfully executed, but Progress bar was not updated. When I refreshed the page, the bar was updated
    bar was not updated

LMK please if I need to create separate issue on any of these cases.

@shoom3301
Copy link
Collaborator Author

@elena-zh

  1. I'm not sure about that, let's ask @anxolin or @fairlighteth
  2. I can't reproduce that :( Create a new issue with steps to reproduce please

@elena-zh elena-zh mentioned this pull request Jul 28, 2023
Closed
elena-zh
elena-zh approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. discussion in https://cowservices.slack.com/archives/C0361CDG8GP/p1690464644954819
  2. separate issue Filled bar for a parent order is not auto-updated (sometimes) #2953

@anxolin anxolin added the RELEASE Included in the release that is being closed label Jul 31, 2023
@shoom3301 shoom3301 changed the base branch from develop to release/1.44.0 July 31, 2023 09:37
@shoom3301 shoom3301 merged commit 3bce96a into release/1.44.0 Jul 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
@alfetopito alfetopito deleted the fix/2941 branch July 31, 2023 09:50
anxolin
anxolin reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@elena-zh elena-zh elena-zh approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed TWAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show all parts of a TWAP order under a parent order
4 participants
@shoom3301 @alfetopito @anxolin @elena-zh