-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(twap): unlimited twap deadline #3568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
reviewed
Jan 3, 2024
shoom3301
reviewed
Jan 3, 2024
apps/cowswap-frontend/src/modules/twap/pure/CustomDeadlineSelector/index.tsx
Outdated
Show resolved
Hide resolved
alfetopito
force-pushed
the
feat/max-limit-order-deadline
branch
from
January 3, 2024 10:40
75624b5
to
1499733
Compare
alfetopito
force-pushed
the
feat/unlimited-twap-deadline
branch
from
January 3, 2024 11:09
266ae71
to
11aad30
Compare
shoom3301
approved these changes
Jan 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to and waterfalls into #3567
Another low hanging fruit from 2024 roadmap
TWAP orders in theory have no duration limit.
The only restriction is that each individual part can not be longer than 6 months.
This change:
To Test
Notes
The new year and month calculation is not very precise.
Thus, you'll see the limit as
6 months and 12h
, when in fact it's182d + 12h
The duration picker is still using hours and minutes
I'm aware it could use some updating, but it's out of the scope of this change.