Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(limit): show price impact warning for Safe App when bundling #3571

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

alfetopito
Copy link
Collaborator

Summary

Fix #3060

Warning wasn't displayed when doing a Limit order with approval bundled.

To Test

  1. Open as Safe app
  2. Go to limit order
  3. Pick a token that needs approval as sell
  4. Pick a pair, set price below market (> 5%)
  • Warning should be displayed
    image
  1. Proceed to confirm screen
  • Warning should require confirmation to proceed
    image
  1. Repeat steps with non-safe wallet
  • Warnings should work as usual

@alfetopito alfetopito self-assigned this Jan 3, 2024
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Jan 9, 2024 0:01am
explorer ❌ Failed (Inspect) Jan 9, 2024 0:01am
swap-dev ✅ Ready (Inspect) Visit Preview Jan 9, 2024 0:01am
widget-configurator ✅ Ready (Inspect) Visit Preview Jan 9, 2024 0:01am

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thank you!

@alfetopito alfetopito force-pushed the fix/3060_no-price-impact-for-approval-bundle branch from e12fb47 to 23448e5 Compare January 9, 2024 11:53
@alfetopito alfetopito merged commit 98a11e7 into develop Jan 9, 2024
9 of 11 checks passed
@alfetopito alfetopito deleted the fix/3060_no-price-impact-for-approval-bundle branch January 9, 2024 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't accept price impact on limit orders
3 participants