fix(swap): fix swap out of market #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
commented
Jan 5, 2024
Comment on lines
+226
to
+227
| // Don't quote if there's nothing left to match in this order | ||
| if (amount === '0') return null |
There was a problem hiding this comment.
Bonus: fix for this issue I observed while testing.
The order would match but still be in the pending list.
This prevent from quoting it and getting unnecessary 400s.
Comment on lines
+266
to
+267
| appData: order.appData ?? undefined, | ||
| appDataHash: order.appDataHash ?? undefined, |
There was a problem hiding this comment.
Bonus: pass the original appData so we can get more precise quotes.
It could have for example the permit hook, which affects the fee price.
| const pendingLimit = useOnlyPendingOrders(chainId, UiOrderType.LIMIT) | ||
| const pendingTwap = useOnlyPendingOrders(chainId, UiOrderType.TWAP) | ||
| const pending = useMemo(() => pendingLimit.concat(pendingTwap), [pendingLimit, pendingTwap]) | ||
| const pending = useOnlyPendingOrders(chainId) |
There was a problem hiding this comment.
We stopped checking for SWAPs since the preparation for TWAP.
This change checks for all order types once again, since we need the indication for all pending orders.
shoom3301
approved these changes
Jan 9, 2024
anxolin
approved these changes
Jan 9, 2024
alfetopito
force-pushed
the
fix/3561_swap-out-of-market
branch
from
82d5bab to
7c03e7e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3561
Swap orders should show out of the market again.
To Test
Check the instructions on #3561