feat(feeZero): deliver fee zero only to 10% of users #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
approved these changes
Jan 12, 2024
alfetopito
approved these changes
Jan 12, 2024
anxolin
added
the
DONT_MERGE
|
Please do not merge until we want to enable the flag in prod (after kaffekranchen) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To launch the fee=0 feature, we already have a feature flag, but we want to delivery it progressively to be able to monitor it
This PR adds a const that allows us to select the % of users we want to see affected by the feature.
It just decides based on the wallet address
Note
This have a effect which is, unless the user is connected, we won't show if the fee=zero is activated
We have to try it out. In principle, i don't think is a big problem, but we have to see if this becomes a bit weird UX
Test
to test it we need to find a wallet that its "selected" to receive the feature.
You can check which of your wallets fits the criteria by running this in the console:
If you have a wallet that matches the criteria, you can verify that once connected, you will have the feature on.
If you struggle to find one, I can help to make a script so you get an account that fits the criteria.