Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token-search): ignore search input case when triggering the search #3620

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

alfetopito
Copy link
Collaborator

Summary

Fixes #3613

The loading state of the token search was not case insensitive

Screen.Recording.2024-01-12.at.12.22.50.mov

To Test

  1. Open the token dropdown and enter a search string
  2. Change the case of any letter
  • Search should remain same as before

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Jan 12, 2024 0:26am
explorer-dev ✅ Ready (Inspect) Visit Preview Jan 12, 2024 0:26am
swap-dev ✅ Ready (Inspect) Visit Preview Jan 12, 2024 0:26am
widget-configurator ✅ Ready (Inspect) Visit Preview Jan 12, 2024 0:26am

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We have a bunch of lint issues (not from this PR). They make sense, I think we should address them

@alfetopito alfetopito merged commit 4568b21 into develop Jan 12, 2024
13 checks passed
@alfetopito alfetopito deleted the fix/3613_fix-search-same-string branch January 12, 2024 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokens search hang in loading state when change a request
3 participants