Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update cow-sdk to 4.1.0 #3660

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat: update cow-sdk to 4.1.0 #3660

merged 1 commit into from
Jan 16, 2024

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Jan 16, 2024

Summary

Fixing issue reported internally here

Essentially, this order displays 0 fee although the value is filled.

It was fixed in cowprotocol/cow-sdk#197

This change simply uses cow-sdk version released with that fix.

To Test

  1. Open the order 0xdedb65b51a6f81493f8e6e1d811b56a57297dbb6fb11716d85e646a66a5d041f85cc3c8da85612013acabe9b5d954d578860b3c165a22c43 in the explorer
  • Fee should not be 0
  1. Play around with different orders
  • Fee should be displayed as usual

@alfetopito alfetopito self-assigned this Jan 16, 2024
@alfetopito alfetopito requested a review from a team January 16, 2024 11:03
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Jan 16, 2024 4:46pm
explorer-dev ✅ Ready (Inspect) Visit Preview Jan 16, 2024 4:46pm
swap-dev ✅ Ready (Inspect) Visit Preview Jan 16, 2024 4:46pm
widget-configurator ✅ Ready (Inspect) Visit Preview Jan 16, 2024 4:46pm

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@cowprotocol/cow-sdk 4.0.7...4.1.0 None +0/-0 1.1 MB

@elena-zh
Copy link
Contributor

Hey @alfetopito , frankly, I don't remember whether it was possible to show fees for a partially filled order with several fills?

@alfetopito
Copy link
Collaborator Author

Hey @alfetopito , frankly, I don't remember whether it was possible to show fees for a partially filled order with several fills?

Good question!

We should show a fee, for sure.

Right now we don't show any on prod either (although there I see a 0 instead).

Checked the data and there's nothing returned by the backend.
Will check with them.

Still, this is a new issue.

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a separate issue for an order with several fils #3666

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants