-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update cow-sdk to 4.1.0 #3660
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Hey @alfetopito , frankly, I don't remember whether it was possible to show fees for a partially filled order with several fills? |
Good question! We should show a fee, for sure. Right now we don't show any on prod either (although there I see a Checked the data and there's nothing returned by the backend. Still, this is a new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a separate issue for an order with several fils #3666
206818c
to
9513c85
Compare
9513c85
to
e056284
Compare
Summary
Fixing issue reported internally here
Essentially, this order displays 0 fee although the value is filled.
It was fixed in cowprotocol/cow-sdk#197
This change simply uses cow-sdk version released with that fix.
To Test
0xdedb65b51a6f81493f8e6e1d811b56a57297dbb6fb11716d85e646a66a5d041f85cc3c8da85612013acabe9b5d954d578860b3c165a22c43
in the explorer0