Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(usd-estimation): add defillama price source #4341

Merged
merged 11 commits into from
May 16, 2024
Merged

feat(usd-estimation): add defillama price source #4341

merged 11 commits into from
May 16, 2024

Conversation

alfetopito
Copy link
Collaborator

Summary

Part of #4238

  • Add Defillama price source as fallback
  • Fix Coingecko rate limit detection
  • Refactor usd price fetching

To Test

  1. On mainnet/gchain, load an account that has many funds and/or many trades with surplus for different tokens
  2. Open the tokens page, open the activity modal page
  3. Open the console in the network tab
  • Once there are coingeckoProxy requests failing with 429 errors, there should be requests for defillama
  1. Open the console logs and filter by UsdPricesUpdater
  • There should be logs indicating when coingecko, defillama or cowprotocol prices are being used

Note

The console logs are noise, I know.
Will remove them before merging.

@alfetopito alfetopito self-assigned this Apr 30, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview May 16, 2024 8:24am
cowfi ✅ Ready (Inspect) Visit Preview May 16, 2024 8:24am
cowfi-new ✅ Ready (Inspect) Visit Preview May 16, 2024 8:24am
explorer-dev ✅ Ready (Inspect) Visit Preview May 16, 2024 8:24am
swap-dev ✅ Ready (Inspect) Visit Preview May 16, 2024 8:24am
widget-configurator ✅ Ready (Inspect) Visit Preview May 16, 2024 8:24am

@alfetopito alfetopito requested review from a team April 30, 2024 16:46
elena-zh
elena-zh approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (but tested in #4345 , as here I was not able to get 429 conigecko requests even after placing 22 limit orders)

@elena-zh
Copy link
Contributor

elena-zh commented May 1, 2024

UPD: also noticed defilama requests in the PR after coingecko ones failed:
image

@alfetopito alfetopito force-pushed the feat/4238_improve-usd-call-caching branch from 706481c to 5ec75ed Compare May 1, 2024 12:58
@alfetopito alfetopito force-pushed the feat/4238_defillama branch from 46891e0 to c3ac4c0 Compare May 1, 2024 12:59
@alfetopito alfetopito force-pushed the feat/4238_defillama branch from c3ac4c0 to cd36b09 Compare May 1, 2024 13:19
@alfetopito alfetopito mentioned this pull request May 1, 2024
Closed
3 tasks
anxolin
anxolin reviewed May 1, 2024
View reviewed changes
apps/cowswap-frontend/src/modules/usdAmount/apis/getCoingeckoUsdPrice.ts Outdated Show resolved Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/apis/getCoingeckoUsdPrice.ts Outdated Show resolved Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/apis/getDefillamaUsdPrice.ts Outdated Show resolved Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/apis/getDefillamaUsdPrice.ts Outdated Show resolved Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/apis/getDefillamaUsdPrice.ts Outdated Show resolved Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/apis/getCoingeckoUsdPrice.ts Outdated Show resolved Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/apis/getDefillamaUsdPrice.ts Show resolved Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/apis/getDefillamaUsdPrice.ts Show resolved Hide resolved
@alfetopito alfetopito force-pushed the feat/4238_improve-usd-call-caching branch from 0b3618b to e41244a Compare May 2, 2024 12:48
@alfetopito alfetopito force-pushed the feat/4238_defillama branch from cd36b09 to 05a3786 Compare May 2, 2024 12:51
anxolin
anxolin reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alfetopito alfetopito force-pushed the feat/4238_defillama branch from 5308823 to 76e3a9f Compare May 15, 2024 17:25
@alfetopito alfetopito force-pushed the feat/4238_defillama branch from 76e3a9f to 262801b Compare May 16, 2024 08:20
@alfetopito alfetopito merged commit 96a0343 into develop May 16, 2024
12 checks passed
@alfetopito alfetopito deleted the feat/4238_defillama branch May 16, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@elena-zh elena-zh elena-zh approved these changes

@shoom3301 shoom3301 Awaiting requested review from shoom3301

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfetopito @elena-zh @anxolin @shoom3301