Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): link hooks page to swap trade state #4698

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Jul 9, 2024

Summary

Fixes #4662 (only points 1 and 2)

When I specify a hook first (pre or post, or both), then try selecting a buy token, the buy token can't be picked. Same for a sell token if I'd like to change it.

When I change a chain in the app, additional chain indicator appears in the URL ?chain=gnosis_chain. And this looks a bit weird to have 2 different chain indicators in the URL. And when I navigate between pages, the app asks to change the chain according to the numeric indicator in the URL

  1. Changed the URL path from /hooks to /swap/hooks because it's more specific
  2. Adjusted trade type detection for Hooks page

To Test

  1. Open hooks page
  2. Try changing sell/buy tokens
  • tokens should be displayed on the page corresponding to the selected value

@shoom3301 shoom3301 requested review from a team July 9, 2024 11:23
@shoom3301 shoom3301 self-assigned this Jul 9, 2024
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Jul 9, 2024 11:37am
cowfi ✅ Ready (Inspect) Visit Preview Jul 9, 2024 11:37am
explorer-dev ✅ Ready (Inspect) Visit Preview Jul 9, 2024 11:37am
swap-dev ✅ Ready (Inspect) Visit Preview Jul 9, 2024 11:37am
widget-configurator ✅ Ready (Inspect) Visit Preview Jul 9, 2024 11:37am

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shoom3301 shoom3301 merged commit bab250c into develop Jul 10, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the fix/hooks-trade-type branch July 10, 2024 08:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.89] Hooks: selling ETH cases to imrove
3 participants