Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallets): add coinshift to allowed domains #4931

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Oct 1, 2024

Summary

Context: https://cowservices.slack.com/archives/C036G0J90BU/p1727685276349879
Allowed using Coinshift with CoW Swap

Test

  • CoWSwap should work with Safe as before

@shoom3301 shoom3301 self-assigned this Oct 1, 2024
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 17, 2024 11:19am
cowfi ✅ Ready (Inspect) Visit Preview Dec 17, 2024 11:19am
cowswap ❌ Failed (Inspect) Dec 17, 2024 11:19am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 11:19am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 17, 2024 11:19am
swap-dev 🔄 Building (Inspect) Visit Preview Dec 17, 2024 11:19am
widget-configurator 🔄 Building (Inspect) Visit Preview Dec 17, 2024 11:19am

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shoom3301 , when I open the app inside the Safe it appears to be not connected
image
image
Same for the widget
image

Could you please take a look at it?

@shoom3301
Copy link
Collaborator Author

@elena-zh fixed

@elena-zh
Copy link
Contributor

elena-zh commented Dec 3, 2024

Hey @shoom3301 , everything is great but the widget: it is not connected when open it inside the Safe:
image

Please. compare it with the Prod:
image

@shoom3301
Copy link
Collaborator Author

@elena-zh it is ok, the widget configurator is not suposed to work in Safe Apps

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue according to this discussion

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants