fix(widget-configurator): use different default partner fee address per chain #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
commented
Oct 3, 2024
Comment on lines
-14
to
+15
| const prKey = window.location.hostname.replace('widget-configurator-git-', '').replace('-cowswap.vercel.app', '') | ||
| return `https://swap-dev-git-${prKey}-cowswap.vercel.app` | ||
| // TODO: revert before merging!! | ||
| return 'https://swap-dev-git-fix-widget-configurator-fee-recipient-cowswap.vercel.app/' |
There was a problem hiding this comment.
Don't forget to revert this before merging!!
shoom3301
approved these changes
Oct 4, 2024
alfetopito
force-pushed
the
fix/widget-configurator-fee-recipient
branch
from
96dd956 to
e53f58c
Compare
alfetopito
force-pushed
the
fix/widget-configurator-fee-recipient
branch
from
e53f58c to
7480038
Compare
alfetopito
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 2024/10/07
Added arb1 address
Changed the types so it accepts the partner fee by network. Default embed code looks like this now, when fee is set:
Summary
Fixes #4937
Note: pointing to main to release is as a hotfix. It should go live as soon as it's merged, not needing a deployment.
To Test