Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yield): fetch balances for LP-tokens #5005

Merged
merged 80 commits into from
Oct 29, 2024
Merged

feat(yield): fetch balances for LP-tokens #5005

merged 80 commits into from
Oct 29, 2024

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Oct 18, 2024 •
edited
Loading

Summary

  1. Extracted VirtualList component in order to reuse it for LP-tokens list
  2. Added styles for the LP-token selector (figma)
  3. Added balances caching. Only >0 values are cached into localStorage
  4. Added balances and allowances fetching for LP-tokens. The fetching mechanism for LP is different:
  • it starts with 3 sec delay
  • it's longer, because it doesn't send all requests at once, but execute them one after another. We have to do that, because node starts answering 429 error due to too much requests
image

To Test

  1. In Yield widget, the token selector should display All, Pool tokens, CoW AMM only tabs
  2. Pool tokens should be displayed
  3. APR is hardcoded, tooltip is hardcoded, LP-token logo is not stylized yet

shoom3301 added 30 commits October 7, 2024 18:18
@shoom3301
feat(yield): setup yield widget
01c23f9
@shoom3301
fix(yield): display correct output amount
e8514b5
@shoom3301
feat(trade-quote): support fast quote requests
4bde353
@shoom3301
feat(yield): display trade buttons
cf63214
@shoom3301
feat(yield): display confirm details
2513c89
@shoom3301
feat(yield): scope context to trade
893859f
@shoom3301
feat(yield): do trade after confirmation
89aeca4
@shoom3301
feat(yield): display order progress bar
ca61cbb
@shoom3301
refactor: move useIsEoaEthFlow to trade module
0e267a9
@shoom3301
refactor: move hooks to tradeSlippage module
2df7b69
@shoom3301
refactor: rename swapSlippage to tradeSlippage
4ff2db5
@shoom3301
feat(trade-slippage): split slippage state by trade type
f5c45e9
@shoom3301
refactor: unlink TransactionSettings from swap module
8b8ae26
@shoom3301
refactor: use reach modal in Settings component
39a95c3
@shoom3301
refactor: move Settings component in trade module
7c3c559
@shoom3301
feat(yield): add settings widget
57d4ad0
@shoom3301
feat(yield): use deadline value from settings
4b8a40d
@shoom3301
fix(trade-quote): skip fast quote if it slower than optimal
2c2ee88
@shoom3301
refactor: generalise TradeRateDetails from swap module
0bbec8b
@shoom3301
refactor: move TradeRateDetails into tradeWidgetAddons module
fbb9a73
@shoom3301
refactor: move SettingsTab into tradeWidgetAddons module
275893e
@shoom3301
refactor(swap): generalise useHighFeeWarning()
452d107
@shoom3301
refactor(swap): move hooks to trade module
27407be
@shoom3301
refactor: move HighFeeWarning to trade widget addons
1073d5f
@shoom3301
refactor: make HighFeeWarning independent
11243ee
@shoom3301
feat(yield): display trade warnings
2548e10 
ZeroApprovalWarning and HighFeeWarning
@shoom3301
refactor(trade): generalise NoImpactWarning
f9e3d82
@shoom3301
refactor(trade): generalise ZeroApprovalWarning
3c6ed69
@shoom3301
refactor(trade): generalise bundle tx banners
8070665
@shoom3301
refactor: extract TradeWarnings
b6d9717
@shoom3301
Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…
5889ea4 
… feat/vampire-attack-lp-tokens

# Conflicts:
#	apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetForm.tsx
#	apps/cowswap-frontend/src/modules/trade/containers/TradeWidgetLinks/styled.ts
@shoom3301
Copy link
Collaborator Author

@elena-zh

  1. I would spend time on special cases in Sepolia. The Yield feature is not really working in this network since there are not so much LPs. Since this is test-net I would keep it as it is.
  2. Fixed
  3. Fixed
  4. This wasn't specified, but I trust you. Changed the link
  5. Fixed
  6. I will implement the sorting in another PR
  7. Implemented in the next PR feat(yield): use lp-token in widget #5013
  8. Implemented in the next PR feat(yield): use lp-token in widget #5013
  9. Fixed in feat: modify pool token list layout #5014

@elena-zh
Copy link
Contributor

Hey @shoom3301 , everything is great besides geo-blocking feature: I still don't see these token lists from the blocked area:
image

@fairlighteth @shoom3301
feat(yield): add unlock screen (#5043)
f74341f 
* feat: add unlock screen for yield tab

* feat: add unlock screen for yield tab

* chore: revert

---------

Co-authored-by: Alexandr Kazachenko <[email protected]>
@shoom3301
Copy link
Collaborator Author

@elena-zh sorry, this case is fixed in the next pr: #5013

elena-zh
elena-zh approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved then!

alfetopito
alfetopito approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue I noticed, when I'm not connected the loading effect is playing
image

@shoom3301
Copy link
Collaborator Author

One issue I noticed, when I'm not connected the loading effect is playing image

Thank you! This is already fixed in another PR

@shoom3301 shoom3301 merged commit 2877df5 into develop Oct 29, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the feat/vampire-attack-lp-tokens branch October 29, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees

@shoom3301 shoom3301

Labels
🧛‍♂️ Vampire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoom3301 @elena-zh @fairlighteth @alfetopito