feat: allow to use same tokens for hooks #5075
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yes is a small bug, I wouldn't give it too much importance, but the solution shouldn't be that hard. I gave a hint in case someone wants to fix it. Ideally someone from the community :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🧪 Experiment to allow to select the same token for the sell and buy when we use hooks.
This allows to use CoW Swap as a gas network.
SWAP (and all other swap flows) remains the same.
However hooks flow, allow to select the same sell/buy token
WIP: quotes are broken, not only in the backend, also in the frontend.
Blocked
The backend sends still a 40X when the sell token and buy token matches
