Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix custom hook alert title and trim slash from url #5117

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: fix custom hook alert title and trim slash from url #5117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130fd23
feat: fix custom hook alert title and trim slash from url
fairlighteth Nov 20, 2024
f2e90d0
feat: fix inline banner margin
fairlighteth Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/cowswap-frontend/src/common/pure/ExternalSourceAlert/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function ExternalSourceAlert({ className, onChange, title, children }: Ex
return (
<styledEl.Contents className={className}>
<AlertTriangle size={48} strokeWidth={1} />
<h3>{title}</h3>
<styledEl.Title>{title}</styledEl.Title>
{children}

<styledEl.AcceptanceBox>
Expand Down
19 changes: 8 additions & 11 deletions apps/cowswap-frontend/src/common/pure/ExternalSourceAlert/styled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,21 @@ export const Contents = styled.div`
color: var(${UI.COLOR_DANGER_TEXT});
background: var(${UI.COLOR_DANGER_BG});

h3 {
font-size: 24px;
text-align: center;
margin: 16px 0;
font-weight: bold;
}

p {
margin: 6px 0;
}

> svg > path,
> svg > line {
stroke: var(${UI.COLOR_DANGER_TEXT});
stroke-width: 2px;
}
`

export const Title = styled.h4`
font-size: 24px;
text-align: center;
margin: 16px 0;
font-weight: bold;
width: 100%;
`

export const AcceptanceBox = styled.label`
display: flex;
gap: 6px;
Expand Down
2 changes: 1 addition & 1 deletion apps/cowswap-frontend/src/modules/hooksStore/pure/AddCustomHookForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export function AddCustomHookForm({ addHookDapp, children, isPreHook, walletType
type="text"
placeholder="Enter a hook dapp URL"
value={input}
onChange={(e) => setInput(e.target.value?.trim())}
onChange={(e) => setInput(e.target.value?.trim().replace(/\/+$/, ''))}
/>

{/* Validation and Error Messages */}
Expand Down
1 change: 1 addition & 0 deletions apps/cowswap-frontend/src/modules/swap/containers/SwapWidget/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ export function SwapWidget({ topContent, bottomContent }: SwapWidgetProps) {
iconSize={24}
orientation={BannerOrientation.Horizontal}
backDropBlur
margin="10px auto auto"
>
Funds stuck? <Link to={cowShedLink}>Recover your funds</Link>
</InlineBanner>
Expand Down
Loading