-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace GA4 and use GTM with data-click-event #5130
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fairlighteth , not sure how to test this , so checked that GA events are not fired (like I did in n #5056 PR.
As for the Mev Blocker copy button: thanks for adding it. I've noticed that on 1280-1540px screen width the icon is shifted to another line
Also, WDYT about adding to the Block explorer URL as well? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fairlighteth , got this. Thank you for clarification, and adding copy buttons to every field :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soft approve
Looks fine technically, but
- How do I test this? Maybe some test instructions on using this with tag manager. Also, nice to give some extra context on why this is important
- There's always the security concern of allowing arbitrary JS injection to the accounts controlling Tag Manager. This has been flagged as a weak security policy, as it can be easy to replace the TRADE button link with a fake UI that would drain user funds. As I'm not responsible of security, I will just limit my part to inform @fedgiac and he can decide if we can look to the other side with this one
In general I have too little context to evaluate the impact of this change: I don't know why it's needed, what alternatives were considered, and especially how this is going to be managed. To my very limited understanding, GTM allows people to execute arbitrary code on the webpage through the GTM console (in the standard case, for tracking purposes). The security risk of this PR by itself is little I suppose (we just trust yet more code from Google), but the problem is how this is going to be used. If I recall correctly, in the past there was a strong push from marketing for implementing and providing liberal access to this tool, which I believe is an easy-to-overlook security risk. Again, I don't have context on how this tooling is used and I certainly don't have the knowledge needed to manage Google Tag Manager and to advise for security, but I think we should avoid adding it unless absolutely necessary. |
Summary
data-click-event