-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yield): use pools info from API #5138
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/cowswap-frontend/src/modules/yield/updaters/VampireAttackUpdater.tsx
Outdated
Show resolved
Hide resolved
… feat/use-vampire-attack-api
@elena-zh the PR is ready for tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shoom3301 , great!
I've been able to test it on Mainnet only as data is still missing on other chains (reported it here).
Also, provided data differs from the one that is displayed on pool provider's app (also reported)
Issues that I've faced:
-
Some pools are missing in a token list, but they are present on the API response
-
Vice versa: pool that are present in a token list, are absent in the API
This is resulting in many 0-data pools on the UI
-
There is an issue with decimals: it is weird to see that CoW AMM pool token 0.0% performs better :)
Thanks!
Summary
cowprotocol/bff#99 - BFF
There are two new endpoints:
To Test
Important!
If there are some issues with data (you see it on the API response), please report it in slack channel about vampire attack.