Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yield): use pools info from API #5138

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Nov 28, 2024

Summary

cowprotocol/bff#99 - BFF

There are two new endpoints:

To Test

  1. The values on UI should match values from API
  2. Values should be updated after network changes

Important!
If there are some issues with data (you see it on the API response), please report it in slack channel about vampire attack.

@shoom3301 shoom3301 requested review from a team November 28, 2024 11:57
@shoom3301 shoom3301 self-assigned this Nov 28, 2024
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 17, 2024 8:57am
cowfi ✅ Ready (Inspect) Visit Preview Dec 17, 2024 8:57am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 8:57am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 17, 2024 8:57am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 8:57am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 17, 2024 8:57am

@shoom3301
Copy link
Collaborator Author

@elena-zh the PR is ready for tests

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shoom3301 , great!
I've been able to test it on Mainnet only as data is still missing on other chains (reported it here).
Also, provided data differs from the one that is displayed on pool provider's app (also reported)
Issues that I've faced:

  1. Some pools are missing in a token list, but they are present on the API response
    missing

  2. Vice versa: pool that are present in a token list, are absent in the API
    image
    This is resulting in many 0-data pools on the UI
    image

  3. There is an issue with decimals: it is weird to see that CoW AMM pool token 0.0% performs better :)
    00
    0 03

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants