Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve orders table when hidden orders #5226

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 17, 2024

Summary

This PR adds 2 things:

  • Another pagination control in the bottom of the table. After all, makes sense to not scroll up to go to next page
  • Makes it more cleat that the page is complete, and there's more pages later

It is not very clear in this table that 19 orders are hidden and I can navigate to next pages. Basically, it looks like there's no more than 1 order.

image

This PR shows the same account like this:

image

You can unhide orders, and the message will update
image

You can click on next page to navigate.

In last page, you don't see the next page link

image

To Test

Search for your orders in the explorer, for example for the account 0x5be9a4959308A0D0c7bC0870E319314d8D957dBB

  • Notice the two paginators
  • Check the cases described above

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 18, 2024 0:18am
cowfi ✅ Ready (Inspect) Visit Preview Dec 18, 2024 0:18am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 18, 2024 0:18am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 18, 2024 0:18am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 18, 2024 0:18am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 18, 2024 0:18am

@elena-zh
Copy link

Hey @anxolin , cool, great!
WDYT about showing this message on top of all orders in the table?
show top

It would be great to improve the message position in a mobile view: this is how it looks now:
image

And it is not related to this task, but if you are taking a look into pagination, it would be great to add it to the Fills page. See this TX details,, it should have >10 fills, but it shows only 10 (the issue is reported in #3703)

@anxolin anxolin requested a review from a team December 18, 2024 10:57
@anxolin
Copy link
Contributor Author

anxolin commented Dec 18, 2024

WDYT about showing this message on top of all orders in the table?

I will ask around

It would be great to improve the message position in a mobile view: this is how it looks now:

Good thinking! I tried, and the problem was that it was showing a big message, which feels too much for such a normal case. So better to show it after the relevant content (the orders).
However, I tried to improve it by moving all to the bottom, and show only the warning in the top. You can see it in the video I share below.

It would be great to improve the message position in a mobile view: this is how it looks now:

I tried to improve, here is a video

Screen.Recording.2024-12-18.at.12.05.56.mov

I also show now a message when all orders are visible
Screenshot at Dec 18 12-02-00

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @anxolin ! It looks better now!

@anxolin anxolin changed the base branch from develop to main December 18, 2024 12:49
@anxolin anxolin merged commit a4aaff9 into main Dec 18, 2024
11 of 13 checks passed
@anxolin anxolin deleted the add-double-pagination branch December 18, 2024 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants