-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve orders table when hidden orders #5226
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/explorer/src/components/orders/OrdersUserDetailsTable/index.tsx
Outdated
Show resolved
Hide resolved
Hey @anxolin , cool, great! It would be great to improve the message position in a mobile view: this is how it looks now: And it is not related to this task, but if you are taking a look into pagination, it would be great to add it to the Fills page. See this TX details,, it should have >10 fills, but it shows only 10 (the issue is reported in #3703) |
I will ask around
Good thinking! I tried, and the problem was that it was showing a big message, which feels too much for such a normal case. So better to show it after the relevant content (the orders).
I tried to improve, here is a video Screen.Recording.2024-12-18.at.12.05.56.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @anxolin ! It looks better now!
Summary
This PR adds 2 things:
It is not very clear in this table that 19 orders are hidden and I can navigate to next pages. Basically, it looks like there's no more than 1 order.
This PR shows the same account like this:
You can unhide orders, and the message will update
You can click on next page to navigate.
In last page, you don't see the next page link
To Test
Search for your orders in the explorer, for example for the account
0x5be9a4959308A0D0c7bC0870E319314d8D957dBB