Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow 1 year max deadline #5227

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: allow 1 year max deadline #5227

merged 1 commit into from
Dec 18, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 17, 2024

Summary

Before this PR, we allowed a maximum deadline of 6 month for limit orders

This PR increases it to 1 year:

image

Test

Place orders of more than 6 months deadline, up to a year

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:08pm
cowfi ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:08pm
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:08pm
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:08pm
swap-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:08pm
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:08pm

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!!

@anxolin anxolin merged commit 64e3f40 into main Dec 18, 2024
11 of 13 checks passed
@anxolin anxolin deleted the increase-deadline-1y branch December 18, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants