Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address pr5244 comments #5263

Merged
merged 2 commits into from
Dec 31, 2024
Merged

chore: address pr5244 comments #5263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e89770
fix: use network instead of orderParams chainId
alfetopito Dec 31, 2024
722e00c
refactor: update comment
alfetopito Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions apps/cowswap-frontend/src/modules/swap/services/ethFlow/steps/signEthFlowOrderStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,19 +67,25 @@ export async function signEthFlowOrderStep(
return GAS_LIMIT_DEFAULT
})

// This used to be done with a higher level of abstraction like this:
// Ensure the Eth flow contract network matches the network where you place the transaction.
// There are multiple wallet implementations, and potential race conditions that can cause the chain of the wallet to be different,
// and therefore leaving the chainId implicit might lead the user to place an order in an unwanted chain.
// This is especially dangerous for Eth Flow orders, because the contract address is different for the distinct networks,
// and this can lead to loss of funds.
//
// Thus, we are not using a higher level of abstraction as it doesn't allow to explicitly set the chainId:
// const txReceipt = await ethFlowContract.createOrder(ethOrderParams, {
// ...ethTxOptions,
// gasLimit: calculateGasMargin(estimatedGas),
// })
// However, to **try** to prevent wallet issues, we want to explicitly send along the chainId
// But that wrapper doesn't accept it.
// So we must build the tx first, then send it using the contract's signer
//
// So we must build the tx first:
const tx = await ethFlowContract.populateTransaction.createOrder(ethOrderParams, {
...ethTxOptions,
gasLimit: calculateGasMargin(estimatedGas),
})
const txReceipt = await ethFlowContract.signer.sendTransaction({ ...tx, chainId: orderParams.chainId })
// Then send the is using the contract's signer where the chainId is an acceptable parameter
const txReceipt = await ethFlowContract.signer.sendTransaction({ ...tx, chainId: network.chainId })

addInFlightOrderId(orderId)

Expand Down
Loading