feat: limit UI upgrade 2 - USD precision #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
alfetopito
force-pushed
the
feat/limit-ui-upgrade-2_price-precision
branch
from
a76a623 to
9d028ac
Compare
alfetopito
changed the title
elena-zh
approved these changes
Jan 10, 2025
alfetopito
force-pushed
the
feat/limit-ui-upgrade-2_price-precision
branch
from
6524adc to
794114d
Compare
anxolin
reviewed
Jan 10, 2025
| @@ -18,7 +18,7 @@ export enum LimitOrderDeadlinePreset { | |||
| ONE_DAY = '1 Day', | |||
| THREE_DAYS = '3 Days', | |||
| ONE_MONTH = '1 Month', | |||
| SIX_MONTHS = '6 Months (max)', | |||
| SIX_MONTHS = '1 Year (max)', | |||
There was a problem hiding this comment.
@alfetopito was this intentional?
I thought it was changed already, and also now it doesn't match te const name and the label
There was a problem hiding this comment.
Yes!
I believe @fairlighteth did some refactoring where the label was reverted back to an earlier version.
Great catch that I forgot to update the label 🤦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Test
fill or killorderShould NOT show insufficient balance
Should use ALL available balance
USD amounts should be a bit less finicky (better with rounding)