Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distance to market #5307

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Jan 17, 2025

Summary

  • Invert distance to market percentage when price display is inverted
  • Be more explicit in the tooltip, by adding the mentioned market price and execution prices
    image
    image
  • Reduce re-renderings by memoizing Price instances

To Test

  1. On limit orders table, observe fills at/distance to market column

@alfetopito alfetopito self-assigned this Jan 17, 2025
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Jan 17, 2025 11:02am
cowfi ✅ Ready (Inspect) Visit Preview Jan 17, 2025 11:02am
explorer-dev ✅ Ready (Inspect) Visit Preview Jan 17, 2025 11:02am
sdk-tools ✅ Ready (Inspect) Visit Preview Jan 17, 2025 11:02am
swap-dev ✅ Ready (Inspect) Visit Preview Jan 17, 2025 11:02am
widget-configurator ✅ Ready (Inspect) Visit Preview Jan 17, 2025 11:02am

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alfetopito , I get the app crash when I open my Limit orders page
скфыр
To reproduce, please impersonate this account on Sepolia: 0x9FA3c00a92Ec5f96B1Ad2527ab41B3932EFEDa58, and open Limit orders page

@elena-zh
Copy link
Contributor

Hey @alfetopito , I get the app crash when I open my Limit orders page скфыр To reproduce, please impersonate this account on Sepolia: 0x9FA3c00a92Ec5f96B1Ad2527ab41B3932EFEDa58, and open Limit orders page

Not related to the current PR. A new task for addressing this issue is opened.

@elena-zh elena-zh self-requested a review January 19, 2025 14:44
@alfetopito alfetopito merged commit ceaabc9 into feat/limit-ui-upgrade-2 Jan 20, 2025
12 of 13 checks passed
@alfetopito alfetopito deleted the fix/distance-to-market branch January 20, 2025 11:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants