Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes done for the last evaluation #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changes done for the last evaluation #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions evaluation_dashboards/app/src/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
UNION_RAW_DATA_JOINED_WITH_PARAMETER = """with raw_data as (
select pa.uid, sell_amount, buy_amount, executed_sell_amount, executed_buy_amount, exchange, name, data, output_value_usd, gas_cost_usd_from_trader_contract, gas_cost_usd_from_trace_callMany, gas_price, sell_token_price, buy_token_price, eth_price, block_number from exchange prd inner join parameters pa on pa.uid = prd.uid
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant to this or, but this line is way too long. Is there any other fields that could be null we maybe want to exclude?

where output_value_usd <> 'NaN' and (executed_sell_amount != 0 or name='cowswap')
ORDER BY block_number DESC limit 10000
where output_value_usd <> 'NaN' and gas_price <> 'NaN' and (executed_sell_amount != 0 or name='cowswap')
ORDER BY block_number DESC limit 50000
),"""
# Since reverted transactions have an executed_sell_amount of zero, we will filter them out. Only cowswap has executed_sell_amount of zer0, as the tx can not be simulated