Add Base network to cow amm surplus query #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harisang
approved these changes
Jan 29, 2025
PoloX2021
added a commit
that referenced
this pull request
Jan 29, 2025
* Lp feed for prices (#120) * First version of the queries * Query to get all the uni style pools categorized by project * Renaming queries with dune id * comment * typo * Sql code to add the incremental data to the whole blockchain * Comments * Adding edge cases for new pools * Supposedly more efficient query, but not enough apparently * taking into account prices that don't exist * filling in the gaps with empty data * Improving filtering * Last filtering mistake * typo * Changing filtering * Changing the base table to get the cow amms from a subquery to a materialized view * Prepare for merge on our own db * Access fewer times the logs table * Removing files in the wrong folder * Commenting code, using materialized view and removing query not on dune * Update cowamm/profitability/lp_prices/uni_style_lp_4420675.sql Co-authored-by: Haris Angelidakis <[email protected]> * Renaming uni style --------- Co-authored-by: Haris Angelidakis <[email protected]> * add base to cow amm surplus query (#125) * fix comment in balance changes query (#126) --------- Co-authored-by: Haris Angelidakis <[email protected]> Co-authored-by: Felix Henneke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for Base network to the CoW AMM bounty on CoW surplus.
Since all queries used within already work on base, only one additional table needed to be added to this query.
The modified query can be tested here.
This has not been rigorously tested. The results seem reasonable. Overall, there do not seem to be any significant CoWs on Base.