This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
[Fetch] Orderbook Rewards #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
force-pushed
the
orderbook-data
branch
from
a23263f to
af8f4a3
Compare
|
@bh2smith Some of the unit tests are failing is this still to be reviewed? |
I am just getting the DB secrets configured here. Just a moment. |
gentrexha
reviewed
Nov 22, 2022
gentrexha
reviewed
Nov 22, 2022
gentrexha
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We migrate a query we have seen before in
solver-rewards(namely the one querying for orderbook rewards on a block range). This block range will be specified as:block_from = the latest synced block (coming in a follow up PR)
block_to = the latest synced block from the two orderbook databases
block_to is implemented here by querying the two databases for the smallest block with
tx_from = Nulltaking the minimum of these two and subtracting 65 (for REORG protection)Follow Up
#6
Test Plan
Tests are introduced for both database queries (however they require database credentials).