Redeploy contracts from the same deployer #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been instances of a user sending ETH to the ETH-flow address in the wrong network, which has a high chance of making the funds completely unrecoverable.
To reduce concerns of this kind, the ETH-flow contract has been redeployed to the same address on all supported chains. There is still a risk when sending a transaction for a network to another one, but in many cases the order should just expire and the refunder should eventually reimburse the user. Note that the deployed doesn't use CREATE2, meaning that there's no guarantee that the contract at the target address is indeed the ETH-flow contract code.
I also added the standard json representation of the solc input (and successfully tested it). If Etherscan verification through the verification script fails (unfortunately, a common occurrence) it should be possible to give verification another shot through the Etherscan web interface.
How to test
Confirm that the barn deployment (0x04501b9b1d52e67f6862d157e00d13419d2d6e95) and the prod one (0xba3cb449bd2b4adddbc894d8697f5170800eadec) exist on all network, that their contract code is verified matches the ETH flow, and that the deployment parameters are the expected ones.