236/solvers details

[matextrem]

Summary

Closes #236

Added Solver details page.

To Test

1. Open the page solvers
2. Click on any solver name either in Active solvers or Settlements table
   • You'll be redirected to the solver details page.

Disclaimer: There are some info left we have to update such as ETH cost and Active since box (it is harcoded right now)

[github-actions]

• 🔭 Explorer: Explorer test app
• 🔒 Safe Swap App: Trade test app (add to your safe apps)
• 📈 Trade: Trade test app
• 📚 Storybook: Component stories

[elena-zh]

Hey @matextrem , nice changes!
List of issues from my side:

1. Full date on the Active since card does not match the format we use for full dates across the app
   

2. There is no Solver name when open the page from Settlements tab
   

3. Frankly, it is not clear to me why we show full amounts on cards when press on Tooltips icons.
   
   We show amounts on hover, and tooltips icons should open explanation modals for this or that field
   

4. I think, it would be great to show a better message when a request to load the page data fails (error loading data, please try again?)
   

5. When Trades amount is not loaded, it shows NaN instead of 0
   

6. When open Solver details page from Active solvers tab in Ethereum, all dates are in June
   

7. Ethereum + Active solvers tab: the last solver in the list does not have a name, so the name is not clickable
   

8. There are no names for solvers in Gorli
   

9. It is impossible to load data for single solvers page from Active Solvers tab in Gnosis chain
   

10. Some token icons (like GNO) are dark
    

11. Text on cards should be better aligned in a tablet/mobile view
    

12. Name and a solver address are not aligned in a real iOS device
    

[elena-zh]

See the notes above

[matextrem]

hey @elena-zh I addressed some of the bugs you shared.

Regarding 1 & 3 it needs to be changed. I left it is since we need to discuss what to put in there. maybe @alongoni could help us in it.

4. We have a notification in place when there is an error. Those errors you are seeing are related to the icons not able to being loaded but it is not related to the solver details info itself.

5. Is that wrong? I opened up another solver and it showed me dates in May. cc: @ramirotw

6. There is no name for that solver. Now, we are showing the address instead.

7. I didn't find the SQL query to fetch solvers name for Gorli. I tried to use the same we are using for Ethereum but the addresses don't match. cc: @alfetopito

8. Yes, we are not getting any info related settlements for Gnosis chain (Subgraph is only returning the ids). cc @ramirotw

9. It was fixed in this PR. When merged, it will be reflected in this PR as well.

[ramirotw]

When open Solver details page from Active solvers tab in Ethereum, all dates are in June

@matextrem @elena-zh This is because that solver was deactivated but the subgraph currently is not handling the toggle of the isSolver flag to false. There's a pending PR in cowprotocol/subgraph#65 to fix that.

To validate whether a mainnet solver is active or not using onchain data:

1. Go to https://etherscan.io/address/0x2c4c28ddbdac9c5e7055b4c863b72ea0149d8afe#readProxyContract
2. In the isSolver section, paste the solver address
3. If the bool response is true then it's active, if empty it's not

[ramirotw]

It is impossible to load data for single solvers page from Active Solvers tab in Gnosis chain

@matextrem this issue is related to #241 (comment)

[elena-zh]

When open Solver details page from Active solvers tab in Ethereum, all dates are in June

@matextrem @elena-zh This is because that solver was deactivated but the subgraph currently is not handling the toggle of the isSolver flag to false. There's a pending PR in cowprotocol/subgraph#65 to fix that.

To validate whether a mainnet solver is active or not using onchain data:

1. Go to https://etherscan.io/address/0x2c4c28ddbdac9c5e7055b4c863b72ea0149d8afe#readProxyContract
2. In the isSolver section, paste the solver address
3. If the bool response is true then it's active, if empty it's not

That is ridiculous :)
The tab name is 'Active solvers'. but we show deactivated solvers at the top of the table.

[elena-zh]

Hey @matextrem , thanks for the explanation.
Here are my notes:

1. For the cases 1, 3, agree, let waif for @alongoni input here
2. 8 case There are no names for solvers in Gorli: why can't we show solvers addresses instead?
3. 9 case: 'It is impossible to load data for single solvers page from Active Solvers tab in Gnosis chain': I believe, it is going to be fixed
4. 11 case Text on cards should be better aligned in a tablet/mobile view: still relevant
   
5. 12 case: looks much better, but still the address is not placed in 1 line with a solver name
   

Thank you!

[ramirotw]

That is ridiculous :)
The tab name is 'Active solvers'. but we show deactivated solvers at the top of the table.

Indeed it's ridiculous, but this is for internal testing before @GabrielCamba deploys the changes to fix it.

[alfetopito]

Looking good so far.

Comments about current progress:

1. Invert the position of timestamp and tx hash columns
   
2. For the tooltips in the solvers detail page, I'm inclined to either: Not show the tool tip OR put a brief and somewhat redundant explanation like

• Trades: Total trades settled by this solver
• Total volume: Total volume settled by this solver
• Total settlements: Total settlements by this solver
• Active since: When the solver became active as was able to submit solutions

3. For the Trades card, add Total => Total trades

And I have a question: are we also limiting the # of settlements we load per individual solver to 1000 like it's done in the general settlements page?

[alfetopito]

Request for a follow up PR:

Update the overall search so when a solver address is searched it leads to the solver details page.

For example. Searching on https://pr241--explorer.review.gnosisdev.com/gc for 0x7942a2b3540d1eC40B2740896f87aEcB2a588731 (Quasimodo's address) should lead you to https://pr241--explorer.review.gnosisdev.com/gc/solvers/0x7942a2b3540d1eC40B2740896f87aEcB2a588731 rather than https://pr241--explorer.review.gnosisdev.com/gc/address/0x7942a2b3540d1eC40B2740896f87aEcB2a588731

[elena-zh]

Update the overall search so when a solver address is searched it leads to the solver details page.

For example. Searching on https://pr241--explorer.review.gnosisdev.com/gc for 0x7942a2b3540d1eC40B2740896f87aEcB2a588731 (Quasimodo's address) should lead you to https://pr241--explorer.review.gnosisdev.com/gc/solvers/0x7942a2b3540d1eC40B2740896f87aEcB2a588731 rather than https://pr241--explorer.review.gnosisdev.com/gc/address/0x7942a2b3540d1eC40B2740896f87aEcB2a588731

Hey @alfetopito , I have created #244 task for this

[elena-zh]

Hey @matextrem , cases 1, 2, 4, 5 from this comment are still not fixed.

Besides, I have another question: since the number of trades is limited with 1000 now, should we show this card on the UI? In most of cases it will always show 1K until we implement a solution how to show more data

[ramirotw]

Hey @matextrem , cases 1, 2, 4, 5 from this comment are still not fixed.

Besides, I have another question: since the number of trades is limited with 1000 now, should we show this card on the UI? In most of cases it will always show 1K until we implement a solution how to show more data

FYI the Total Settlements number will be updated once the subgraph update is deployed, hopefully by the EOW.

[matextrem]

Looking good so far.

Comments about current progress:

1. Invert the position of timestamp and tx hash columns
   
2. For the tooltips in the solvers detail page, I'm inclined to either: Not show the tool tip OR put a brief and somewhat redundant explanation like

• Trades: Total trades settled by this solver
• Total volume: Total volume settled by this solver
• Total settlements: Total settlements by this solver
• Active since: When the solver became active as was able to submit solutions

3. For the Trades card, add Total => Total trades

And I have a question: are we also limiting the # of settlements we load per individual solver to 1000 like it's done in the general settlements page?

Yes, we are limiting the amount of settlements to 1000 as well.

[matextrem]

Hey @matextrem , cases 1, 2, 4, 5 from this comment are still not fixed.

Besides, I have another question: since the number of trades is limited with 1000 now, should we show this card on the UI? In most of cases it will always show 1K until we implement a solution how to show more data

Hey @elena-zh! I updated the branch with the feedback.

Regarding point 2, It's working for me.

Regarding 5, I don't fully understand what's the behavior you want here. They are vertically centered on Tablet/Mobile view :

Maybe @alongoni could give feedback on this as well.

[elena-zh]

Hey @matextrem , overall, changes look good to me. But:

Regarding point 2, It's working for me.

Please, take a look at the Settlements tab. Active solvers tab looks good.

Thanks!

[matextrem]

@elena-zh updated!

[elena-zh]

Hey @matextrem , changes LGTM now.
We still have issues related to the Supgraph:

• Total settlements are 1000 for a single solver, and on Settlements table
• No ETH cost
• Do 'Active since'

Also, I have created a separate task to adjust pagination displaying on tables across the whole app #246.

Thanks