Attempt to the fix

cowprotocol · Oct 8, 2024 · 56f5358 · 56f5358
1 parent 5809401
commit 56f5358
Show file tree

Hide file tree

Showing 4 changed files with 388 additions and 88 deletions.
diff --git a/crates/driver/src/domain/competition/solution/encoding.rs b/crates/driver/src/domain/competition/solution/encoding.rs
@@ -312,7 +312,7 @@ struct Flags {
     buy_token_balance: order::BuyTokenBalance,
 }
 
-mod codec {
+pub mod codec {
     use crate::domain::{competition::order, eth};
 
     // cf. https://github.com/cowprotocol/contracts/blob/v1.5.0/src/contracts/libraries/GPv2Trade.sol#L16
@@ -392,7 +392,7 @@ mod codec {
         )
     }
 
-    pub(super) fn signature(signature: &order::Signature) -> super::Bytes<Vec<u8>> {
+    pub fn signature(signature: &order::Signature) -> super::Bytes<Vec<u8>> {
         match signature.scheme {
             order::signature::Scheme::Eip712 | order::signature::Scheme::EthSign => {
                 signature.data.clone()

diff --git a/crates/driver/src/infra/api/routes/quote/dto/quote.rs b/crates/driver/src/infra/api/routes/quote/dto/quote.rs
@@ -1,6 +1,6 @@
 use {
     crate::{
-        domain::{self, eth, quote},
+        domain::{self, competition::solution::encoding::codec, eth, quote},
         util::serialize,
     },
     model::{
@@ -106,7 +106,7 @@ impl From<domain::competition::solution::trade::Jit> for JitOrder {
             side: jit.order().side.into(),
             sell_token_source: jit.order().sell_token_balance.into(),
             buy_token_destination: jit.order().buy_token_balance.into(),
-            signature: jit.order().signature.data.clone().into(),
+            signature: codec::signature(&jit.order().signature).0,
             signing_scheme: jit.order().signature.scheme.to_boundary_scheme(),
         }
     }