Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tokio console opt-in via env variable (#2878)
# Description The `tokio-console` comes with some pretty hefty memory overhead that caused many pods to crashloop due to OOM issues which I didn't expect. Therefore we should not have it enabled by default. However, I still think it's valuable to have support for the feature baked in by default to reduce the friction of actually using the feature. # Changes Now you have to set `TOKIO_CONSOLE=true` to enable it. This flag does not show up in the `--help` text and only in the repo `README.md` because otherwise it would have to be added a bit awkwardly and passed around a lot which I didn't really like in the previous iteration to begin with. I think this is okay because it's just a debugging thing and not knowing about the flag doesn't prevent you from using the binaries correctly but LMK if you disagree and I should parse the arg via `clap` instead. ## How to test Ran a local test with and without `TOKIO_CONSOLE=true`
- Loading branch information