-
Notifications
You must be signed in to change notification settings - Fork 90
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop settlement_call_data table (#2968)
# Description Since we don't need to store then uninternalised and internalised calldata, so the table `settlement_call_data` can be dropped. PR rebased on top of #2964 as a continuation of it. # Changes - Drop the table `settlement_call_data` ## How to test 1. Regression tests ## Related Issues Fixes #2939 --------- Co-authored-by: Martin Magnus <[email protected]>
- Loading branch information
1 parent
8c863d5
commit d1458fa
Showing
4 changed files
with
5 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- We don't need to store the uninternalised and internalised calldata, so this table can be dropped | ||
--- This is because we don't need to show/return the calldata from the competition endpoints for safety reasons | ||
--- The calldata can be recovered using any full node given the transaction hash which is later recovered when observing the settlement | ||
--- See more: https://github.com/cowprotocol/services/issues/2942 | ||
DROP TABLE settlement_call_data; |