You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This field was added when surplus_fee for limit orders was calculated before order execution (and even was periodically recalculated before, during and after the limit order was executed). The field was added to capture the value at execution time.
Since this functionality is dropped and limit orders now get the fee from solvers, we can also drop this column, since for limit orders is zero, while for market orders is equal to solvers_fee from the order struct which is constant over time, so it's basically a duplicated data.
The text was updated successfully, but these errors were encountered:
sunce86
changed the title
chore: Drop solver_fee column from order_executions table
chore: Drop solver_fee column from order_execution table
Nov 30, 2023
# Description
See related issues for context
# Changes
- [x] Drop `auction_transactions` table
- [x] Drop `solver_fee` column (always null now)
## How to test
Run migration locally
## Related Issues
Fixes#2350 & #2100
Background
This field was added when
surplus_fee
for limit orders was calculated before order execution (and even was periodically recalculated before, during and after the limit order was executed). The field was added to capture the value at execution time.Since this functionality is dropped and limit orders now get the fee from solvers, we can also drop this column, since for limit orders is zero, while for market orders is equal to
solvers_fee
from theorder
struct which is constant over time, so it's basically a duplicated data.The text was updated successfully, but these errors were encountered: